Builtin Cohere Command Processor #2165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
raulb
requested changes
Feb 26, 2025
There was a problem hiding this comment.
Thank you @parikshitg !
I believe we need to run make generate to create the JSON spec so it can be later pulled into conduit site: https://github.com/ConduitIO/conduit-site/tree/main/src/processorgen/specs.
My comments here are pretty similar than in #2167 (review) if it helps.
|
Thanks @raulb for your reviews. I have made the requested changes. |
* feat: embed processor * update mod file * resolved PR comments, added batching support & test cases * fix: header in embed_examples_test.go * fix: update examples test and generate json spec * resolved PR comments --------- Co-authored-by: Gaurav Sahil <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This includes Cohere's command processor.
Quick checks