Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing of the preview.pipeline-arch-v2 flag #2177

Merged
merged 3 commits into from
Feb 27, 2025
Merged

Fix parsing of the preview.pipeline-arch-v2 flag #2177

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a021ac3
Fix parsing of the preview.pipeline-arch-v2 flag
hariso Feb 26, 2025
69eca29
Merge branch 'main' into haris/fix-flag-pipeline-arch-v2
hariso Feb 26, 2025
27c30e5
Merge branch 'main' into haris/fix-flag-pipeline-arch-v2
hariso Feb 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions cmd/conduit/root/config/config_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ func TestConfigWithFlags(t *testing.T) {
"--pipelines.path", "/var/lib/conduit/pipelines",
"--preview.pipeline-arch-v2=true",
"--processors.path", "/opt/conduit/processors",
"--schema-registry.confluent.connection-string", "http://localhost:8081",
"--schema-registry.confluent.connection-string", "http://localhost:8888",
"--schema-registry.type", "confluent",
"--dev.blockprofile", "/tmp/block.prof",
"--dev.cpuprofile", "/tmp/cpu.prof",
Expand All @@ -106,8 +106,8 @@ func TestConfigWithFlags(t *testing.T) {
"pipelines.error-recovery.max-retries: 10",
"pipelines.error-recovery.max-retries-window: 15m0s",
"schema-registry.type: confluent",
"schema-registry.confluent.connection-string: http://localhost:8081",
"preview.pipeline-arch-v2: false",
"schema-registry.confluent.connection-string: http://localhost:8888",
"preview.pipeline-arch-v2: true",
"dev.cpuprofile: /tmp/cpu.prof",
"dev.memprofile: /tmp/mem.prof",
"dev.blockprofile: /tmp/block.prof",
Expand Down
2 changes: 1 addition & 1 deletion pkg/conduit/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ type Config struct {

Preview struct {
// PipelineArchV2 enables the new pipeline architecture.
PipelineArchV2 bool `long:"preview.pipeline-arch-v2" usage:"enables experimental pipeline architecture v2 (note that the new architecture currently supports only 1 source and 1 destination per pipeline)"`
PipelineArchV2 bool `long:"preview.pipeline-arch-v2" mapstructure:"pipeline-arch-v2" usage:"enables experimental pipeline architecture v2 (note that the new architecture currently supports only 1 source and 1 destination per pipeline)"`
}

Dev struct {
Expand Down