Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs): sdk usage #123

Open
wants to merge 33 commits into
base: main
Choose a base branch
from
Open

feat(docs): sdk usage #123

wants to merge 33 commits into from

Conversation

sdimitris
Copy link
Contributor

@sdimitris sdimitris commented Dec 5, 2022

Docs related to sdk usages.

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other (please describe)

Does this PR introduce a breaking change?

  • Yes
  • No

The PR fulfills these requirements:

  • It's submitted to the main branch
  • When resolving a specific issue, it's referenced in the PR's description (e.g. fix #xxx, where "xxx" is the issue number)

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature

Other information:

@netlify
Copy link

netlify bot commented Dec 5, 2022

Deploy Preview for trusting-goodall-362511 canceled.

Name Link
🔨 Latest commit 73a3a6c
🔍 Latest deploy log https://app.netlify.com/sites/trusting-goodall-362511/deploys/63a439b4e16fd9000a919d5a

@netlify
Copy link

netlify bot commented Dec 5, 2022

Deploy Preview for mystifying-borg-373afd ready!

Name Link
🔨 Latest commit 73a3a6c
🔍 Latest deploy log https://app.netlify.com/sites/mystifying-borg-373afd/deploys/63a439b448f04b0008ba45a6
😎 Deploy Preview https://deploy-preview-123--mystifying-borg-373afd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sdimitris sdimitris marked this pull request as draft December 5, 2022 12:49
@sdimitris sdimitris changed the title Sdk sage Sdk usage Dec 5, 2022
@kon14 kon14 changed the title Sdk usage feah: sdk usage Dec 5, 2022
@kon14 kon14 changed the title feah: sdk usage feat: sdk usage Dec 5, 2022
@kon14 kon14 changed the title feat: sdk usage feat(docs): sdk usage Dec 5, 2022
@sdimitris sdimitris marked this pull request as ready for review December 5, 2022 14:53
Copy link
Contributor

@kon14 kon14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated Authentication and Chat SDK sections and partially updated Database as a reference.
I replaced codeblock titles (in the above pages) with Request and Response as a lot of these were copy-pasted or otherwise inaccurate.

Please take care of the following:

  • jsx -> ts codeblocks
  • remove this and catches, keep stuff concise
  • rename all codeblock titles to Request and Response
  • provide response codeblocks where relevant
  • make sure request/response objects have valid signatures (please don't type these manually)
  • remove any remaining references to adult movie content in the Database

kon14 and others added 5 commits December 16, 2022 15:53
… into sdk_sage

# Conflicts:
#	documentation/versioned_docs/version-v0.15/modules/authentication/sdk_usage.mdx
#	documentation/versioned_docs/version-v0.15/modules/chat/sdk_usage.mdx
#	documentation/versioned_docs/version-v0.15/modules/database/sdk_usage.mdx
@sdimitris sdimitris requested a review from kon14 January 2, 2023 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants