refactor(core,admin): remove catch clauses (#871)

this is done so that initialization errors properly crash the core module, since recovery is not possible at that stage
ConduitPlatform · Jan 3, 2024 · 2d7be12 · 2d7be12
1 parent 9b2c31c
commit 2d7be12
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 11 deletions.
diff --git a/packages/admin/src/index.ts b/packages/admin/src/index.ts
@@ -113,12 +113,7 @@ export default class AdminModule extends IConduitAdmin {
         patchRouteMiddlewares: this.patchRouteMiddlewares.bind(this),
       },
     );
-    this.grpcSdk
-      .waitForExistence('database')
-      .then(this.handleDatabase.bind(this))
-      .catch(e => {
-        ConduitGrpcSdk.Logger.error(e.message);
-      });
+    this.grpcSdk.waitForExistence('database').then(this.handleDatabase.bind(this));
   }
 
   async subscribeToBusEvents() {

diff --git a/packages/core/src/GrpcServer.ts b/packages/core/src/GrpcServer.ts
@@ -23,7 +23,10 @@ export class GrpcServer {
   private readonly server: ConduitGrpcServer;
   private readonly events: EventEmitter;
 
-  constructor(private readonly commons: ConduitCommons, private readonly port: number) {
+  constructor(
+    private readonly commons: ConduitCommons,
+    private readonly port: number,
+  ) {
     this.events = new EventEmitter();
     this.events.setMaxListeners(150);
     this.server = new ConduitGrpcServer(this.port.toString());
@@ -99,10 +102,7 @@ export class GrpcServer {
     this.initializeMetrics();
     this._grpcSdk
       .waitForExistence('database')
-      .then(() => this.commons.getConfigManager().registerAppConfig())
-      .catch(e => {
-        ConduitGrpcSdk.Logger.error(e.message);
-      });
+      .then(() => this.commons.getConfigManager().registerAppConfig());
     await this.commons
       .getConfigManager()
       .configurePackage(