Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core,grpc-sdk,module-tools): rework service-discover, health checking and module communication #1268

Merged
merged 5 commits into from
Jan 3, 2025

Conversation

kkopanidis
Copy link
Contributor

This PR re-works the health checking and service discovery systems of the core module, to facilitate proper load-balancing and high-availability for module connections.

Brief changes:

  • Modules now get an instance id that publish to the core module
  • Modules are represented as a collection of instances with separate addresses.
  • Health checking is happening on individual services based on their calling IP, not their published URL
  • Core publishes list of addresses or the published URL if it is a domain

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other (please describe)

Does this PR introduce a breaking change?

  • Yes
  • No

The PR fulfills these requirements:

  • It's submitted to the main branch
  • When resolving a specific issue, it's referenced in the PR's description (e.g. fix #xxx, where "xxx" is the issue number)

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature

Other information:

@kkopanidis kkopanidis marked this pull request as ready for review December 26, 2024 18:01
@kkopanidis kkopanidis merged commit e7d25cf into v-next Jan 3, 2025
2 checks passed
@kkopanidis kkopanidis deleted the ha/health-checks branch January 3, 2025 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants