Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(database): SQL createView() already exists race condition #688

Merged
merged 1 commit into from
Sep 21, 2023
Merged

fix(database): SQL createView() already exists race condition #688

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 20 additions & 7 deletions modules/database/src/adapters/sequelize-adapter/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,16 +71,29 @@ export abstract class SequelizeAdapter extends DatabaseAdapter<SequelizeSchema>
dialect !== 'sqlite'
? `CREATE OR REPLACE VIEW ${queryViewName} AS ${query.sqlQuery}`
: `CREATE VIEW IF NOT EXISTS" ${queryViewName} AS ${query.sqlQuery}`;
await this.sequelize.query(viewQuery);
await this.sequelize.query(viewQuery).catch(err => {
if (
err.name !== 'SequelizeUniqueConstraintError' &&
(err.name !== 'SequelizeDatabaseError' || !err.message.includes('already exists'))
) {
throw err;
}
});
this.views[viewName] = viewModel;
const foundView = await this.models['Views'].findOne({ name: viewName });
if (isNil(foundView)) {
await this.models['Views'].create({
name: viewName,
originalSchema: modelName,
joinedSchemas: [...new Set(joinedSchemas.concat(modelName))],
query,
});
await this.models['Views']
.create({
name: viewName,
originalSchema: modelName,
joinedSchemas: [...new Set(joinedSchemas.concat(modelName))],
query,
})
.catch(err => {
if (err.name !== 'SequelizeUniqueConstraintError') {
throw err;
}
});
}
}

Expand Down