Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Simplify computation of checksum and words #959

Closed
wants to merge 9 commits into from

Conversation

Tabaie
Copy link
Contributor

@Tabaie Tabaie commented Dec 12, 2023

This PR integrates the process of breaking up the input into words and computing the checksum into one out-of-snark function.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How has this been tested?

In e2e_test.go a few new tests for the integrated words/checksum function have been added.

How has this been benchmarked?

Not benchmarked.

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I did not modify files generated from templates
  • golangci-lint does not output errors locally
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@gbotrel
Copy link
Collaborator

gbotrel commented Jan 22, 2024

@Tabaie I assume this PR is outdated and we can close ?

@Tabaie Tabaie closed this Jan 22, 2024
@gbotrel gbotrel deleted the refact/compress-checksum branch January 17, 2025 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants