Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display name fix for SWAP1-SWAP5 instructions #665

Merged
merged 3 commits into from
Feb 12, 2025
Merged

Display name fix for SWAP1-SWAP5 instructions #665

merged 3 commits into from
Feb 12, 2025

Conversation

OlivierBBB
Copy link
Collaborator

@OlivierBBB OlivierBBB commented Feb 10, 2025 •
edited
Loading

Fixes bug whereby SWAP1 was displayed as LOG0 in the inspector. Likely also affected SWAP2, ..., SWAP5.

@OlivierBBB
Update compiler.go
93f94f0 
Fixes bug whereby `SWAP1` was displayed as `LOG0` in the inspector.
@cla-assistant CLA Assistant
Copy link

cla-assistant bot commented Feb 10, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@cla-assistant CLA Assistant
Copy link

cla-assistant bot commented Feb 10, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@OlivierBBB OlivierBBB changed the title Update compiler.go Display name fix for SWAP1-SWAP5 instructions Feb 10, 2025
DavePearce
DavePearce approved these changes Feb 10, 2025
View reviewed changes
Copy link
Collaborator

@DavePearce DavePearce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OlivierBBB OlivierBBB enabled auto-merge (squash) February 11, 2025 23:55
@OlivierBBB OlivierBBB merged commit f62049a into main Feb 12, 2025
3 checks passed
@OlivierBBB OlivierBBB deleted the SWAP-LOG-display-name-bug-fix branch February 12, 2025 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavePearce DavePearce DavePearce approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OlivierBBB @DavePearce