Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save and restore bundle pool #157

Merged
merged 1 commit into from
Mar 6, 2025

Conversation

fab-10
Copy link
Contributor

@fab-10 fab-10 commented Mar 3, 2025

With this PR the bundle pool is saved on disk in a file, when Besu stops and when Besu starts if the save file is present then populated the bundle pool with the content of that save file.

The save file is versioned, so if in future if bundles will have more fields then we can easily bump the version to support the new format.

Fixes #160

@fab-10 fab-10 self-assigned this Mar 3, 2025
@fab-10 fab-10 force-pushed the save-restore-bundle-pool branch from 92a47ce to fdc8ba1 Compare March 6, 2025 12:06
@fab-10 fab-10 marked this pull request as ready for review March 6, 2025 12:06
@fab-10 fab-10 force-pushed the save-restore-bundle-pool branch 2 times, most recently from d16afa4 to c7add67 Compare March 6, 2025 13:41
Copy link
Contributor

@garyschulte garyschulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks solid. One suggestion about requiring a record terminator as an indication that the [last] line is well formed

Signed-off-by: Fabio Di Fabio <[email protected]>
@fab-10 fab-10 force-pushed the save-restore-bundle-pool branch from c7add67 to 00f00d9 Compare March 6, 2025 15:39
Copy link
Contributor

@garyschulte garyschulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@fab-10 fab-10 merged commit 13e0753 into Consensys:main Mar 6, 2025
6 checks passed
@fab-10 fab-10 deleted the save-restore-bundle-pool branch March 6, 2025 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Save and restore bundle pool
2 participants