Optimize snap #36
Merged
Optimize snap #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This optimizes the loading of the homepage UI, changes the onInstall dialog, and provides a better way to set the watch address.
Please have a look at these changes, and if you approve, please publish a new version of the Snap to npm.
Also, I think we should consider adding a timestamp to certain information being loaded. For example, it does not make sense to load the activations from netlify on every request. That information could probably be cached for at least 5 minutes. You could store a timestamp in manageState with the last time the activations were loaded, and if it has been less than 5 minutes, just load that information from state instead of calling netlify again.