-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework deprecated functionality #159
Conversation
Codecov Report
@@ Coverage Diff @@
## master #159 +/- ##
==========================================
+ Coverage 91.03% 91.39% +0.35%
==========================================
Files 269 266 -3
Lines 6294 6227 -67
Branches 1229 1214 -15
==========================================
- Hits 5730 5691 -39
+ Misses 314 290 -24
+ Partials 250 246 -4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
…ted to typeString parser only
I think we should not merge until we stabilize Scribble behavior, while it is using this branch. See failures in Consensys/scribble#200. |
…ng of MemberAccess.
…d instead of empty tuple
…ned if it fails to process type name
…le for interfaces
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 note and 1 question.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last question, sorry I forgot one file last review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. Some issues for follow up work.
Preface
Previously we introduced new
InferType
component in #142 and #152 PRs, also in 10.3.0 release. We also realized that it would impact on backward compatibility due to older type inference functions would significantly change their interface. We postponed this step for a while to inform dependent packages about further changes. This PR reworks a lot of deprectaed functions and adapts them to a newer type inference approach.Changes
ModuleType
andInaccessibleDynamicType
for tests only (remove from common codebase).Notes
eq()
to work properly with reserved primitive / elementary types #160.InferType
for type inference and drop usage of deprecated functions scribble#200.Regards.