updated proposer logic for maxEB #8343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added test to show that the consolidation factor affects the proposals in an epoch. Proposer index 3 went from 0 proposals in epoch 1 up to 4 proposals in epoch 1 after this change (consolidation of 16, so it has 16x32 eth) Signed-off-by: Paul Harris <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
ethereum/spec/src/main/java/tech/pegasys/teku/spec/logic/common/helpers/MiscHelpers.java
Fixed
Show fixed
Hide fixed
|
We'll need to update reftests before this will be clean by the looks. |
tbenr
approved these changes
May 29, 2024
.../test/java/tech/pegasys/teku/spec/logic/versions/electra/helpers/MiscHelpersElectraTest.java
Show resolved
Hide resolved
Signed-off-by: Paul Harris <[email protected]>
Signed-off-by: Paul Harris <[email protected]>
Signed-off-by: Paul Harris <[email protected]>
ethereum/spec/src/main/java/tech/pegasys/teku/spec/logic/common/helpers/MiscHelpers.java
Dismissed
Show dismissed
Hide dismissed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added test to show that the consolidation factor affects the proposals in an epoch.
Proposer index 3 went from 0 proposals in epoch 1 up to 4 proposals in epoch 1 after this change (consolidation of 16, so it has 16x32 eth)
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog