Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SszOptionalSchema bounds #8484

Merged
merged 3 commits into from
Jul 30, 2024
Merged

Fix SszOptionalSchema bounds #8484

merged 3 commits into from
Jul 30, 2024

Conversation

tbenr
Copy link
Contributor

@tbenr tbenr commented Jul 30, 2024

fixes #8412

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

@tbenr tbenr requested a review from zilm13 July 30, 2024 13:47
zilm13
zilm13 approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@zilm13 zilm13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!
Thank you for addressing this

@tbenr tbenr enabled auto-merge (squash) July 30, 2024 15:27
@tbenr tbenr changed the title Fix ssz optional bounds Fix SszOptionalSchema bounds Jul 30, 2024
@tbenr tbenr merged commit cd2e889 into Consensys:master Jul 30, 2024
15 checks passed
zilm13 pushed a commit to zilm13/teku that referenced this pull request Jul 31, 2024
@tbenr @zilm13
Fix ssz optional bounds (Consensys#8484)
cd549d5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zilm13 zilm13 zilm13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix SszLengthBounds for SszOptinal
2 participants
@tbenr @zilm13