BeaconChainController.start() future should complete when all services started #8981
Conversation
Nashatyrev
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -347,12 +347,17 @@ | |||
| LOG.debug("Starting {}", this.getClass().getSimpleName()); | |||
| forkChoiceExecutor.start(); | |||
| return initialize() | |||
| .thenCompose(__ -> timerService.start()) | |||
Check notice
Code scanning / CodeQL
Useless parameter Note
| @@ -347,12 +347,17 @@ | |||
| LOG.debug("Starting {}", this.getClass().getSimpleName()); | |||
| forkChoiceExecutor.start(); | |||
| return initialize() | |||
| .thenCompose(__ -> timerService.start()) | |||
| .thenCompose(__ -> recentChainData.getStoreInitializedFuture()) | |||
Check notice
Code scanning / CodeQL
Useless parameter Note
| (err) -> LOG.debug("rejected execution poll failed", err))); | ||
| public SafeFuture<Void> start() { | ||
| return SafeFuture.of(metricsEndpoint.start()) | ||
| .thenCompose(__ -> metricsPublisher.start()) |
Check notice
Code scanning / CodeQL
Useless parameter Note
| public SafeFuture<Void> start() { | ||
| return SafeFuture.of(metricsEndpoint.start()) | ||
| .thenCompose(__ -> metricsPublisher.start()) | ||
| .thenCompose(__ -> getServiceController().start()) |
Check notice
Code scanning / CodeQL
Useless parameter Note
|
Oh, it looks like that doesn't work with pre-genesis start. Services are expected to start after genesis only. |
PR Description
PR addresses the issue described in comment: #8980 (comment)
BeaconChainController.start()returnedFutureshould complete when all 'sub-services' are up and runningSystem.exit()to the upper level from theBeaconChainControllerto have more control on startup errors (for example in unit tests)Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog