Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update process_registry_updates #9060

Merged
merged 2 commits into from
Jan 31, 2025
Merged

update process_registry_updates #9060

merged 2 commits into from
Jan 31, 2025

Conversation

rolfyone
Copy link
Contributor

  • looking at 4104 in consensus-specs, its relatively simple to change our processRegistryUpdates to do this.

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

@rolfyone
update process_registry_updates
f728b3d 
 - looking at 4104 in consensus-specs, its relatively simple to change our processRegistryUpdates to do this.

Signed-off-by: Paul Harris <[email protected]>
tbenr
tbenr approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@tbenr tbenr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. but you back-ported the change to phase0 but spec are still on plain ifs

@rolfyone
Copy link
Contributor Author

i had also optimised electra before the spec PR...

@rolfyone rolfyone merged commit 3096044 into Consensys:master Jan 31, 2025
16 checks passed
@rolfyone rolfyone deleted the procress-registry-updates branch January 31, 2025 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbenr tbenr tbenr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rolfyone @tbenr