Rocks subcommand #9067
Merged
Rocks subcommand #9067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
storage/src/main/java/tech/pegasys/teku/storage/server/rocksdb/RocksDbHelper.java
Fixed
Show fixed
Hide fixed
storage/src/main/java/tech/pegasys/teku/storage/server/rocksdb/RocksDbHelper.java
Fixed
Show fixed
Hide fixed
rolfyone
reviewed
Feb 2, 2025
storage/src/main/java/tech/pegasys/teku/storage/server/rocksdb/RocksDbHelper.java
Outdated
Show resolved
Hide resolved
rolfyone
reviewed
Feb 2, 2025
Comment on lines
+76
to
+80
| @Command( | ||
| name = "stats", | ||
| description = "Print rocksdb stats", | ||
| mixinStandardHelpOptions = true, | ||
| versionProvider = PicoCliVersionProvider.class) |
There was a problem hiding this comment.
this one is a whole hard thing to read, Im wondering if something like a column filter or something would be useful...
There was a problem hiding this comment.
Another option is print a better header rather than the in-line which doesnt really make anything at all clear...
There was a problem hiding this comment.
hrm maybe i was reading it wrongly, this isnt so bad...
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
Column Family: FINALIZED_STATES_BY_SLOT
so maybe a filter option for the column?
There was a problem hiding this comment.
Can we add this filter on a separate PR? I don't think this is crucial for what I'm trying to get this PR merged in.
There was a problem hiding this comment.
thats fine, the history is just so long its not usable and you need to redirect to file.
Signed-off-by: Paul Harris <[email protected]>
Signed-off-by: Paul Harris <[email protected]>
gfukushima
force-pushed
the
rocks-subcommand
branch
from
00540b6 to
8f752e8
Compare
rolfyone
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This a lift and shift from a tool implemented on Besu that we could use to analyse the db when using RockDb.
Fixed Issue(s)
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog