Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check keystores passwords before running doppelganger detection #9086

Merged

Conversation

mehdi-aouadi
Copy link
Contributor

@mehdi-aouadi mehdi-aouadi commented Feb 5, 2025

PR Description

Check the keystores passwords before running the doppelganger detection when loading validator key via the Keymanager API

Fixed Issue(s)

#9083

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

@mehdi-aouadi mehdi-aouadi force-pushed the 9083-dg-check-keystores-passwords branch from 4690377 to 9d99d29 Compare February 5, 2025 22:01
Copy link
Contributor

@rolfyone rolfyone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mehdi-aouadi mehdi-aouadi enabled auto-merge (squash) February 6, 2025 08:54
@mehdi-aouadi mehdi-aouadi disabled auto-merge February 6, 2025 12:23
@mehdi-aouadi mehdi-aouadi enabled auto-merge (squash) February 6, 2025 12:26
@mehdi-aouadi mehdi-aouadi merged commit d21ad08 into Consensys:master Feb 6, 2025
16 checks passed
@mehdi-aouadi mehdi-aouadi self-assigned this Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants