Added GetPendingDeposits #9110
Merged
Added GetPendingDeposits #9110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Partially addresses ethereum/beacon-APIs#500 Attempting to access this data prior to electra will fail with a 400. Signed-off-by: Paul Harris <[email protected]>
lucassaldanha
approved these changes
Feb 12, 2025
| .description( | ||
| "Returns pending deposits for state with given 'stateId'. Should return 400 if requested before electra.") | ||
| .pathParam(PARAMETER_STATE_ID) | ||
| .tags(TAG_BEACON, TAG_EXPERIMENTAL) |
There was a problem hiding this comment.
i can remove it but its not currently approved is all
| if (!maybeStateAndMetadata | ||
| .get() | ||
| .getMilestone() | ||
| .isGreaterThanOrEqualTo(SpecMilestone.ELECTRA)) { |
There was a problem hiding this comment.
NIT: I think we need a isLessThan() method for our Milestone check... This would read much better as isLessThan(SpecMilestone.ELECTRA) (and without negating the whole expression).
There was a problem hiding this comment.
thats what i looked for first, i guess i could change it
Signed-off-by: Paul Harris <[email protected]>
Signed-off-by: Paul Harris <[email protected]>
Signed-off-by: Paul Harris <[email protected]>
Signed-off-by: Paul Harris <[email protected]>
mehdi-aouadi
added a commit
that referenced
this pull request
Feb 18, 2025
* 25.2.0 Cleanup (#9109) * update electra fork epoch (#9093) * update electra epoch version Signed-off-by: gconnect <[email protected]> * Remove MAX_REQUEST_BLOB_SIDECARS Signed-off-by: gconnect <[email protected]> * Add MAX_REQUEST_BLOB_SIDECARS Signed-off-by: gconnect <[email protected]> --------- Signed-off-by: gconnect <[email protected]> Co-authored-by: Enrico Del Fante <[email protected]> * Add `SingleAttestation` in pretty print (#9101) * Add SingleAttestation in pretty print * Add SingleAttestation in pretty print * Added GetPendingDeposits (#9110) Partially addresses ethereum/beacon-APIs#500 Attempting to access this data prior to electra will fail with a 400. Signed-off-by: Paul Harris <[email protected]> * upgrade besu library (#9116) Signed-off-by: Gabriel Fukushima <[email protected]> * added getPendingPartialWithdrawals api for electra (#9113) Partially addresses ethereum/beacon-APIs#500 Attempting to access this data prior to electra will fail with a 400. Signed-off-by: Paul Harris <[email protected]> * Improve attestation selection (#9114) * improve attestation selection * add test * improvements * no need for entrySet * rename var --------- Co-authored-by: Paul Harris <[email protected]> * fix mev gaslimit warning (#9136) * builder-json-parsing-fix (#9135) * set Accept header in getPayload (#9137) --------- Signed-off-by: gconnect <[email protected]> Signed-off-by: Paul Harris <[email protected]> Signed-off-by: Gabriel Fukushima <[email protected]> Co-authored-by: Lucas Saldanha <[email protected]> Co-authored-by: Glory Agatevure <[email protected]> Co-authored-by: Enrico Del Fante <[email protected]> Co-authored-by: Paul Harris <[email protected]> Co-authored-by: Gabriel Fukushima <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses ethereum/beacon-APIs#500
Attempting to access this data prior to electra will fail with a 400.
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog