Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Accept header in builder getPayload #9137

Merged
merged 3 commits into from
Feb 18, 2025

Conversation

tbenr
Copy link
Contributor

@tbenr tbenr commented Feb 18, 2025

fixes #9131

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

@tbenr tbenr changed the title Set Accept header in getPayload Set Accept header in builder getPayload Feb 18, 2025
Copy link
Contributor

@mehdi-aouadi mehdi-aouadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Just a nit

@tbenr tbenr enabled auto-merge (squash) February 18, 2025 10:32
@tbenr tbenr merged commit edf44ca into master Feb 18, 2025
18 checks passed
@tbenr tbenr deleted the accept-header-in-builder-getPayload branch February 18, 2025 10:54
mehdi-aouadi added a commit that referenced this pull request Feb 18, 2025
* 25.2.0 Cleanup (#9109)

* update electra fork epoch (#9093)

* update electra epoch version

Signed-off-by: gconnect <[email protected]>

* Remove MAX_REQUEST_BLOB_SIDECARS

Signed-off-by: gconnect <[email protected]>

* Add MAX_REQUEST_BLOB_SIDECARS

Signed-off-by: gconnect <[email protected]>

---------

Signed-off-by: gconnect <[email protected]>
Co-authored-by: Enrico Del Fante <[email protected]>

* Add `SingleAttestation` in pretty print (#9101)

* Add SingleAttestation in pretty print

* Add SingleAttestation in pretty print

* Added GetPendingDeposits (#9110)

Partially addresses ethereum/beacon-APIs#500

Attempting to access this data prior to electra will fail with a 400.

Signed-off-by: Paul Harris <[email protected]>

* upgrade besu library (#9116)

Signed-off-by: Gabriel Fukushima <[email protected]>

* added getPendingPartialWithdrawals api for electra (#9113)

Partially addresses ethereum/beacon-APIs#500

Attempting to access this data prior to electra will fail with a 400.

Signed-off-by: Paul Harris <[email protected]>

* Improve attestation selection (#9114)

* improve attestation selection

* add test

* improvements

* no need for entrySet

* rename var

---------

Co-authored-by: Paul Harris <[email protected]>

* fix mev gaslimit warning (#9136)

* builder-json-parsing-fix (#9135)

* set Accept header in getPayload (#9137)

---------

Signed-off-by: gconnect <[email protected]>
Signed-off-by: Paul Harris <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
Co-authored-by: Lucas Saldanha <[email protected]>
Co-authored-by: Glory Agatevure <[email protected]>
Co-authored-by: Enrico Del Fante <[email protected]>
Co-authored-by: Paul Harris <[email protected]>
Co-authored-by: Gabriel Fukushima <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unset Accept header in builder getPayload call
2 participants