Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added regression metrics and support for multi-modal data using dictionaries #1685

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

spartanjoax
Copy link

Hi all,

I have created a fork to contribute to Avalanche. My problem is a regression problem using multi-modal data and noticed that Avalanche did not support this natively. I have added RMSE and R2 metrics, as well as forgetting metrics for both, and modified also the library to handle batches that use dictionaries of tensors instead of just tensors, to handle multi-modal data. This second point address issue #1678. I have blackend the code as well. Please let me know if everything looks good.

Best regards,
Joaquín

@spartanjoax
Copy link
Author

It seems the readthedocs failed because it is using a prior version of sklearn which uses the deprecated mean_squared_error function to calculate the RMSE and my proposed metric uses the new version which calls directly the new root_mean_squared_error. Should I modify my code to use the deprecated function?

@AntonioCarta
Copy link
Collaborator

Thanks, the changes look good. Can you also add the new classes to the API documentation?

Should I modify my code to use the deprecated function?

is it possibile to support both? Either by checking the scikit-learn version or by try/catching the import. Otherwise we can add a version constraint, although it's better to avoid it if possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants