쿠폰 할인 유형 관련 싱크업 #172
Merged
쿠폰 할인 유형 관련 싱크업 #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
설명: - #171 을 참고하세요.
설명: - DiscountValue 필드를 삭제 후, discountFlatValue, discountFlatRate 로 응답받도록 수정했습니다. - 추가 요구사항인 최대 할인 한도 설정 필드를 추가했습니다. - 할인 값 관련 유효성 검사 메소드를 추가했습니다. - 중복 제거를 위해 추상 클래스를 선언하여 중복되는 메소드를 상위 클래스에 등록하여 사용하도록 수정했습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #171