Made aws lambda, event, iam role and stack name configurable 🔧

CoorpAcademy · Mar 11, 2019 · 972ff2a · 972ff2a
1 parent a7f7a2f
commit 972ff2a
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 8 deletions.
diff --git a/serverless-default-config.yml b/serverless-default-config.yml
@@ -1,5 +1,10 @@
 # Fallback Config for codepipeline-watch
-stack-name: the-codepipeline-watch
+aws:
+  stackName: codepipeline-watch-${opt:stage, 'production'}
+  lambdaName: codepipeline-watch
+  eventName: CodepipelineWatchCloudwatchEventTrigger
+  scalingRoleName: CodepipelineWatchDynamodbScalingRoleFor${self:provider.region}
+  lambdaRoleName: CodepipelineWatchAccessRoleFor${self:provider.region}
 github:
   token: token-to--be-defined
 slack: 

diff --git a/serverless-empty-config.yml b/serverless-empty-config.yml
@@ -1,5 +1,5 @@
 # Fallback Empty file for when no config-file is provided
-stack-name:
+aws:
 github:
 slack:
 dynamodb:
diff --git a/serverless.yml b/serverless.yml
@@ -1,7 +1,7 @@
 service: codepipeline-watch
 
 provider:
-  stackName: ${opt:stack-name, self:custom.config.overrides.stack-name, "codepipeline-watch-${opt:stage, 'production'}"}
+  stackName: ${self:custom.config.aws.stackName}
   name: aws
   stage: ${opt:stage, 'production'}
   runtime: nodejs8.10
@@ -15,6 +15,12 @@ package:
 
 custom:
   config:
+    aws:
+      stackName: ${opt:stack-name, self:custom.config.overrides.aws.stackName, self:custom.config.default.aws.stackName}
+      lambdaName: ${self:custom.config.overrides.aws.lambdaName, self:custom.config.default.aws.lambdaName}
+      eventName: ${self:custom.config.overrides.aws.eventName, self:custom.config.default.aws.eventName}
+      scalingRoleName: ${self:custom.config.overrides.aws.scalingRoleName, self:custom.config.default.aws.scalingRoleName}
+      lambdaRoleName: ${self:custom.config.overrides.aws.lambdaRoleName, self:custom.config.default.aws.lambdaRoleName}
     default: ${file(./serverless-default-config.yml)}
     overrides: ${file(${opt:config-file, './serverless-empty-config.yml'})}
     slack:
@@ -24,7 +30,6 @@ custom:
       token: ${self:custom.config.overrides.github.token, env:GITHUB_AUTH_TOKEN, self:custom.config.default.github.token}
     dynamodb:
       table: ${self:custom.config.overrides.dynamodb.table, env:DYNAMODB_TABLE, self:custom.config.default.dynamodb.table}
-      # §todo: more config to be added
       capacity:
           read: ${self:custom.config.overrides.dynamodb.capacity.read, self:custom.config.default.dynamodb.capacity.read}
           write: ${self:custom.config.overrides.dynamodb.capacity.write, self:custom.config.default.dynamodb.capacity.write}
@@ -45,7 +50,7 @@ functions:
 
   codepipeline-watch:
     handler: lambda/aws-slack-codepipeline-watch.handler
-    name: codepipeline-watch
+    name: ${self:custom.config.aws.lambdaName}
     role: CodepipelineWatchLambdaRole
     memorySize: 128
     timeout: 60
@@ -57,7 +62,7 @@ functions:
         Ref: DynamoTable
     events:
       - cloudwatchEvent:
-          name: CodepipelineWatchCloudwatchEventTrigger
+          name: ${self:custom.config.aws.eventName}
           description: "Event triggering CodepipelineWatch from codepipeline events"
           event:
             source:
@@ -112,7 +117,7 @@ resources:
     ScalingRole:
       Type: AWS::IAM::Role
       Properties:
-        RoleName: CodepipelineWatchDynamodbScalingRoleFor${self:provider.region}
+        RoleName: ${self:custom.config.aws.scalingRoleName}
         AssumeRolePolicyDocument:
           Version: "2012-10-17"
           Statement:
@@ -168,7 +173,7 @@ resources:
     CodepipelineWatchLambdaRole:
       Type: AWS::IAM::Role
       Properties:
-        RoleName: CodepipelineWatchAccessRoleFor${self:provider.region}
+        RoleName: ${self:custom.config.aws.lambdaRoleName}
         AssumeRolePolicyDocument:
           Version: "2012-10-17"
           Statement: