PHP-CPP: PHP 8.4 support #535
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
module.h - function signature changed https://github.com/php/php-src/blob/91f0b3bc0416539f64c44d453100274ccae942b3/Zend/zend_API.c#L2582 classimpl.cpp - doc_comment moved out of info.user https://github.com/php/php-src/blob/91f0b3bc0416539f64c44d453100274ccae942b3/Zend/zend.h#L224 iteratorimpl.(cpp|h) - valid now returns zend_result https://github.com/php/php-src/blob/91f0b3bc0416539f64c44d453100274ccae942b3/Zend/zend_iterators.h#L39
aidvu
commented
Nov 21, 2024
| @@ -179,17 +179,23 @@ class Module | |||
| // this is not possible if the module is invalid in the first place | |||
| if (!valid()) return false; | |||
|
|
|||
| #if PHP_VERSION_ID < 80400 | |||
| // the Zend engine sets a number of properties in the entry class, we do that here too | |||
| // note that it would be better to call zend_next_free_module() to find the next module | |||
| // number, but some users complain that this function is not always available | |||
| _entry->type = MODULE_TEMPORARY; | |||
| _entry->module_number = zend_hash_num_elements(&module_registry) + 1; | |||
There was a problem hiding this comment.
Explicitly uses zend_next_free_module inside zend_register_module_ex.
Open
|
Sadly this segfaults the same as the PR I submitted when attempting to use the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
module.h - function signature changed
https://github.com/php/php-src/blob/91f0b3bc0416539f64c44d453100274ccae942b3/Zend/zend_API.c#L2582
classimpl.cpp -
doc_commentmoved out ofinfo.userhttps://github.com/php/php-src/blob/91f0b3bc0416539f64c44d453100274ccae942b3/Zend/zend.h#L224
iteratorimpl.(cpp|h) - valid now returns
zend_resulthttps://github.com/php/php-src/blob/91f0b3bc0416539f64c44d453100274ccae942b3/Zend/zend_iterators.h#L39
PHP Docs for 8.4 internals: https://github.com/php/php-src/blob/php-8.4.1/UPGRADING.INTERNALS