Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(new tool) Floating Point Number Converter #1348

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Rapha149
Copy link

I added a tool to convert between decimal numbers and floating point binary numbers (IEEE 754). This can be done in both 32 and 64 bit format and the tool also shows the hexadecimal representation, the actually stored value and the error due to rounding during conversion when converting from decimal to binary.

I hope I did everything correctly and to JS as well as this project's standards, I don't know much about JS and for the layout etc. just pieced together pieces from other tools.

I also added the locales for English and German as those are languages I personally know. If I should add translations for the other languages as well please let me know, but I will do it using DeepL / Google Translate.

If someone knows how to remove the vertical space below the switch here, I would be glad to implement it. I could not figure out how and it annoys me a bit:

screenshot

Copy link

vercel bot commented Oct 16, 2024

@Rapha149 is attempting to deploy a commit to the Corentin Thomasset's Team Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

sonarcloud bot commented Oct 16, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
2 Security Hotspots

See analysis details on SonarCloud

@Rapha149
Copy link
Author

Rapha149 commented Oct 16, 2024

So, I fixed all the convention errors and warnings. I didn't know about the commands pnpm lint and pnpm typecheck before.

Regarding the security warning from SonarCloud: I don't know enough about Regex to determine whether the expression I used to remove the trailing zeros is vulnerable to backtracking.

And lastly, I'm guessing the failed Vercel check is something I can't fix.

@Rapha149 Rapha149 changed the title Add tool floating-point-number-converter. feat(new tool) Floating Point Number Converter Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant