Skip to content

Commit

Permalink
Set new paramers for gov module in sdk v0.47 (#661)
Browse files Browse the repository at this point in the history
# Description

# Reviewers checklist:
- [ ] Try to write more meaningful comments with clear actions to be taken.
- [ ] Nit-picking should be unblocking. Focus on core issues.

# Authors checklist
- [x] Provide a concise and meaningful description
- [x] Review the code yourself first, before making the PR.
- [x] Annotate your PR in places that require explanation.
- [x] Think and try to split the PR to smaller PR if it is big.
  • Loading branch information
miladz68 authored Sep 26, 2023
1 parent 52c8d17 commit 9f55a60
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions app/upgrade/v3/upgrade.go
Original file line number Diff line number Diff line change
Expand Up @@ -161,9 +161,9 @@ func New(
// TODO(new-gov-params): Discuss new values for the following params with the team and set here & inside genesis.v3.json.
// min_initial_deposit_ratio, burn_vote_quorum, burn_proposal_deposit_prevote, burn_vote_veto
govParams := govKeeper.GetParams(ctx)
govParams.MinInitialDepositRatio = sdk.NewDec(0).Quo(sdk.NewDec(100)).String()
govParams.MinInitialDepositRatio = sdk.NewDec(50).Quo(sdk.NewDec(100)).String()
govParams.BurnVoteQuorum = false
govParams.BurnProposalDepositPrevote = false
govParams.BurnProposalDepositPrevote = true
govParams.BurnVoteVeto = true
if err := govKeeper.SetParams(ctx, govParams); err != nil {
return nil, err
Expand Down
4 changes: 2 additions & 2 deletions integration-tests/upgrade/params_migration_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -169,9 +169,9 @@ func (pmt *paramsMigrationTest) After(t *testing.T) {
Quorum: pmt.govParamsBeforeMigration.TallyParams.Quorum.String(),
Threshold: pmt.govParamsBeforeMigration.TallyParams.Threshold.String(),
VetoThreshold: pmt.govParamsBeforeMigration.TallyParams.VetoThreshold.String(),
MinInitialDepositRatio: sdk.ZeroDec().String(),
MinInitialDepositRatio: sdk.MustNewDecFromStr("0.5").String(),
BurnVoteQuorum: false,
BurnProposalDepositPrevote: false,
BurnProposalDepositPrevote: true,
BurnVoteVeto: true,
}
assertT.Equal(paramsBeforeMigration, govParams)
Expand Down

0 comments on commit 9f55a60

Please sign in to comment.