Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timeout to CI jobs #1011

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Add timeout to CI jobs #1011

merged 1 commit into from
Oct 25, 2024

Conversation

alinetskyi
Copy link
Contributor

@alinetskyi alinetskyi commented Oct 24, 2024

Description

Reviewers checklist:

  • Try to write more meaningful comments with clear actions to be taken.
  • Nit-picking should be unblocking. Focus on core issues.

Authors checklist

  • Provide a concise and meaningful description
  • Review the code yourself first, before making the PR.
  • Annotate your PR in places that require explanation.
  • Think and try to split the PR to smaller PR if it is big.

This change is Reviewable

@alinetskyi alinetskyi self-assigned this Oct 24, 2024
@alinetskyi alinetskyi requested a review from a team as a code owner October 24, 2024 11:26
@alinetskyi alinetskyi requested review from masihyeganeh, dzmitryhil, miladz68 and ysv and removed request for a team October 24, 2024 11:26
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.24%. Comparing base (4b12f1d) to head (88132a3).
Report is 24 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1011   +/-   ##
=======================================
  Coverage   63.24%   63.24%           
=======================================
  Files         158      158           
  Lines       18292    18292           
=======================================
  Hits        11569    11569           
  Misses       5692     5692           
  Partials     1031     1031           
Flag Coverage Δ
coreum 57.77% <ø> (ø)
coreum-integration-tests-modules 52.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@miladz68 miladz68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dzmitryhil, @masihyeganeh, and @ysv)

Copy link
Contributor

@masihyeganeh masihyeganeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dzmitryhil and @ysv)

@alinetskyi alinetskyi merged commit daf0635 into master Oct 25, 2024
11 checks passed
@alinetskyi alinetskyi deleted the add_timeout_to_ci branch October 25, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants