Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test DEX messages and queries in wasm #1012

Merged
merged 14 commits into from
Oct 29, 2024
Merged

Conversation

masihyeganeh
Copy link
Contributor

@masihyeganeh masihyeganeh commented Oct 24, 2024

Description

Test DEX messages and queries in wasm
Use module_query_safe for gRPC query accept list
Update rust dependencies

Reviewers checklist:

  • Try to write more meaningful comments with clear actions to be taken.
  • Nit-picking should be unblocking. Focus on core issues.

Authors checklist

  • Provide a concise and meaningful description
  • Review the code yourself first, before making the PR.
  • Annotate your PR in places that require explanation.
  • Think and try to split the PR to smaller PR if it is big.

This change is Reviewable

@masihyeganeh masihyeganeh requested a review from a team as a code owner October 24, 2024 11:34
@masihyeganeh masihyeganeh requested review from dzmitryhil, miladz68 and ysv and removed request for a team October 24, 2024 11:34
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 73.91304% with 12 lines in your changes missing coverage. Please review.

Project coverage is 63.24%. Comparing base (daf0635) to head (fecdb2d).
Report is 23 commits behind head on master.

Files with missing lines Patch % Lines
testutil/integration/coreum.go 0.00% 8 Missing ⚠️
x/wasm/handler/query.go 89.18% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1012      +/-   ##
==========================================
- Coverage   63.24%   63.24%   -0.01%     
==========================================
  Files         158      158              
  Lines       18292    18324      +32     
==========================================
+ Hits        11569    11589      +20     
- Misses       5692     5702      +10     
- Partials     1031     1033       +2     
Flag Coverage Δ
coreum 57.78% <65.21%> (+<0.01%) ⬆️
coreum-integration-tests-modules 52.49% <86.84%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@dzmitryhil dzmitryhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 44 files reviewed, 1 unresolved discussion (waiting on @masihyeganeh, @miladz68, and @ysv)


integration-tests/contracts/modules/ft/src/msg.rs line 18 at r2 (raw file):

    pub uri_hash: Option<String>,
    pub extension_settings: Option<ExtensionIssueSettings>,
    pub dex_settings: Option<DexSettings>,

DexSetting - Uppercase DEX, same for GO, and the custom ?

miladz68
miladz68 previously approved these changes Oct 25, 2024
Copy link
Contributor

@miladz68 miladz68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 29 of 37 files at r1, 15 of 15 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @masihyeganeh and @ysv)

Copy link
Contributor Author

@masihyeganeh masihyeganeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dzmitryhil and @ysv)


integration-tests/contracts/modules/ft/src/msg.rs line 18 at r2 (raw file):

Previously, dzmitryhil (Dzmitry Hil) wrote…

DexSetting - Uppercase DEX, same for GO, and the custom ?

But this is auto generated from the proto

dzmitryhil
dzmitryhil previously approved these changes Oct 25, 2024
Copy link
Contributor

@dzmitryhil dzmitryhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ysv)

@masihyeganeh masihyeganeh dismissed stale reviews from dzmitryhil and miladz68 via cf5929b October 25, 2024 10:53
Copy link
Contributor Author

@masihyeganeh masihyeganeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 27 of 37 files at r1, 14 of 15 files at r2, 3 of 3 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ysv)

Copy link
Contributor Author

@masihyeganeh masihyeganeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ysv)

Copy link
Contributor

@miladz68 miladz68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ysv)

Copy link
Contributor

@ysv ysv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 27 of 37 files at r1, 14 of 15 files at r2, 3 of 3 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @masihyeganeh)

@masihyeganeh masihyeganeh merged commit 11a451e into master Oct 29, 2024
11 checks passed
@masihyeganeh masihyeganeh deleted the masih/dex-wasm-test branch October 29, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants