-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test DEX messages and queries in wasm #1012
Conversation
429527f
to
cb0b14a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1012 +/- ##
==========================================
- Coverage 63.24% 63.24% -0.01%
==========================================
Files 158 158
Lines 18292 18324 +32
==========================================
+ Hits 11569 11589 +20
- Misses 5692 5702 +10
- Partials 1031 1033 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 44 files reviewed, 1 unresolved discussion (waiting on @masihyeganeh, @miladz68, and @ysv)
integration-tests/contracts/modules/ft/src/msg.rs
line 18 at r2 (raw file):
pub uri_hash: Option<String>, pub extension_settings: Option<ExtensionIssueSettings>, pub dex_settings: Option<DexSettings>,
DexSetting - Uppercase DEX
, same for GO, and the custom ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 29 of 37 files at r1, 15 of 15 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @masihyeganeh and @ysv)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dzmitryhil and @ysv)
integration-tests/contracts/modules/ft/src/msg.rs
line 18 at r2 (raw file):
Previously, dzmitryhil (Dzmitry Hil) wrote…
DexSetting - Uppercase
DEX
, same for GO, and the custom ?
But this is auto generated from the proto
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ysv)
cf5929b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 27 of 37 files at r1, 14 of 15 files at r2, 3 of 3 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ysv)
cf5929b
to
fecdb2d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ysv)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ysv)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 27 of 37 files at r1, 14 of 15 files at r2, 3 of 3 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @masihyeganeh)
Description
Test DEX messages and queries in wasm
Use module_query_safe for gRPC query accept list
Update rust dependencies
Reviewers checklist:
Authors checklist
This change is