Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEX whitelist test #1016

Merged
merged 16 commits into from
Oct 30, 2024
Merged

DEX whitelist test #1016

merged 16 commits into from
Oct 30, 2024

Conversation

masihyeganeh
Copy link
Contributor

@masihyeganeh masihyeganeh commented Oct 29, 2024

Description

Reviewers checklist:

  • Try to write more meaningful comments with clear actions to be taken.
  • Nit-picking should be unblocking. Focus on core issues.

Authors checklist

  • Provide a concise and meaningful description
  • Review the code yourself first, before making the PR.
  • Annotate your PR in places that require explanation.
  • Think and try to split the PR to smaller PR if it is big.

This change is Reviewable

@masihyeganeh masihyeganeh requested a review from a team as a code owner October 29, 2024 08:14
@masihyeganeh masihyeganeh requested review from dzmitryhil, miladz68 and ysv and removed request for a team October 29, 2024 08:14
Base automatically changed from masih/dex-wasm-test to master October 29, 2024 18:54
Copy link
Contributor Author

@masihyeganeh masihyeganeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dzmitryhil, @miladz68, and @ysv)

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.25%. Comparing base (11a451e) to head (89ebed1).
Report is 22 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1016      +/-   ##
==========================================
- Coverage   63.24%   61.25%   -2.00%     
==========================================
  Files         158      158              
  Lines       18324    18324              
==========================================
- Hits        11589    11224     -365     
- Misses       5702     6081     +379     
+ Partials     1033     1019      -14     
Flag Coverage Δ
coreum 57.78% <ø> (ø)
coreum-integration-tests-modules 46.88% <ø> (-5.61%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@miladz68 miladz68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dzmitryhil and @ysv)

Copy link
Contributor

@ysv ysv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dzmitryhil)

@masihyeganeh masihyeganeh merged commit 7618a7b into master Oct 30, 2024
11 checks passed
@masihyeganeh masihyeganeh deleted the masih/dex-whitelist-test branch October 30, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants