Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enabled optimistic execution #1018

Merged
merged 3 commits into from
Nov 7, 2024
Merged

enabled optimistic execution #1018

merged 3 commits into from
Nov 7, 2024

Conversation

miladz68
Copy link
Contributor

@miladz68 miladz68 commented Nov 5, 2024

Description

Reviewers checklist:

  • Try to write more meaningful comments with clear actions to be taken.
  • Nit-picking should be unblocking. Focus on core issues.

Authors checklist

  • Provide a concise and meaningful description
  • Review the code yourself first, before making the PR.
  • Annotate your PR in places that require explanation.
  • Think and try to split the PR to smaller PR if it is big.

This change is Reviewable

@miladz68 miladz68 requested a review from a team as a code owner November 5, 2024 08:17
@miladz68 miladz68 requested review from masihyeganeh, dzmitryhil and ysv and removed request for a team November 5, 2024 08:17
Copy link
Contributor

@dzmitryhil dzmitryhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @masihyeganeh, @miladz68, and @ysv)


app/app.go line 331 at r1 (raw file):

	ibclocalhost.RegisterInterfaces(interfaceRegistry)

	baseAppOptions = append(baseAppOptions, baseapp.SetOptimisticExecution())

Is it app or node specific?

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.25%. Comparing base (f4ed2d1) to head (7da59a3).
Report is 29 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1018   +/-   ##
=======================================
  Coverage   63.25%   63.25%           
=======================================
  Files         158      158           
  Lines       18327    18329    +2     
=======================================
+ Hits        11592    11594    +2     
  Misses       5702     5702           
  Partials     1033     1033           
Flag Coverage Δ
coreum 57.81% <100.00%> (+<0.01%) ⬆️
coreum-integration-tests-modules 53.07% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@masihyeganeh masihyeganeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @miladz68 and @ysv)

Copy link
Contributor Author

@miladz68 miladz68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dzmitryhil and @ysv)


app/app.go line 331 at r1 (raw file):

Previously, dzmitryhil (Dzmitry Hil) wrote…

Is it app or node specific?

app specific

Copy link
Contributor

@dzmitryhil dzmitryhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ysv)

@miladz68 miladz68 merged commit 0bd8960 into master Nov 7, 2024
11 checks passed
@miladz68 miladz68 deleted the milad/enable-optimistic-exec branch November 7, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants