Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decrease the gas required for the module's integration tests to pass. #1020

Merged

Conversation

dzmitryhil
Copy link
Contributor

@dzmitryhil dzmitryhil commented Nov 7, 2024

Description

Decrease the gas required for the module's integration tests to pass.

  • Update funding balances
  • Move heavy integration tests to stress tests

Reviewers checklist:

  • Try to write more meaningful comments with clear actions to be taken.
  • Nit-picking should be unblocking. Focus on core issues.

Authors checklist

  • Provide a concise and meaningful description
  • Review the code yourself first, before making the PR.
  • Annotate your PR in places that require explanation.
  • Think and try to split the PR to smaller PR if it is big.

This change is Reviewable

* Update funding balances
* Move heavy integration tests to stress tests
@dzmitryhil dzmitryhil requested a review from a team as a code owner November 7, 2024 12:58
@dzmitryhil dzmitryhil requested review from masihyeganeh, miladz68 and ysv and removed request for a team November 7, 2024 12:58
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.23%. Comparing base (0bd8960) to head (7be68ed).
Report is 28 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1020      +/-   ##
==========================================
+ Coverage   61.24%   63.23%   +1.99%     
==========================================
  Files         158      158              
  Lines       18329    18329              
==========================================
+ Hits        11226    11591     +365     
+ Misses       6083     5704     -379     
- Partials     1020     1034      +14     
Flag Coverage Δ
coreum 57.81% <ø> (ø)
coreum-integration-tests-modules 53.05% <ø> (+6.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@masihyeganeh masihyeganeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 10 of 10 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @miladz68 and @ysv)

Copy link
Contributor

@miladz68 miladz68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 10 of 10 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ysv)

@dzmitryhil dzmitryhil merged commit a8bb968 into master Nov 11, 2024
11 checks passed
@dzmitryhil dzmitryhil deleted the dzmitryhil/improve-tests-by-moving-heavy-tests-to-stress branch November 11, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants