Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated go version 1.23.3 #1026

Merged
merged 4 commits into from
Nov 21, 2024
Merged

updated go version 1.23.3 #1026

merged 4 commits into from
Nov 21, 2024

Conversation

miladz68
Copy link
Contributor

@miladz68 miladz68 commented Nov 19, 2024

Description

Reviewers checklist:

  • Try to write more meaningful comments with clear actions to be taken.
  • Nit-picking should be unblocking. Focus on core issues.

Authors checklist

  • Provide a concise and meaningful description
  • Review the code yourself first, before making the PR.
  • Annotate your PR in places that require explanation.
  • Think and try to split the PR to smaller PR if it is big.

This change is Reviewable

@miladz68 miladz68 requested a review from a team as a code owner November 19, 2024 10:37
@miladz68 miladz68 requested review from masihyeganeh, dzmitryhil and ysv and removed request for a team November 19, 2024 10:37
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 87.71930% with 7 lines in your changes missing coverage. Please review.

Project coverage is 63.28%. Comparing base (9d1fbbd) to head (8a4f09b).
Report is 22 commits behind head on master.

Files with missing lines Patch % Lines
testutil/integration/chain.go 0.00% 2 Missing ⚠️
x/asset/ft/client/cli/tx.go 33.33% 2 Missing ⚠️
cmd/cored/cosmoscmd/generate_network.go 0.00% 1 Missing ⚠️
cmd/cored/main.go 0.00% 1 Missing ⚠️
pkg/client/tx.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1026      +/-   ##
==========================================
- Coverage   63.29%   63.28%   -0.01%     
==========================================
  Files         159      159              
  Lines       18320    18318       -2     
==========================================
- Hits        11596    11593       -3     
- Misses       5694     5695       +1     
  Partials     1030     1030              
Flag Coverage Δ
coreum 57.85% <80.70%> (-0.02%) ⬇️
coreum-integration-tests-modules 53.29% <90.19%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

masihyeganeh
masihyeganeh previously approved these changes Nov 20, 2024
Copy link
Contributor

@masihyeganeh masihyeganeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 11 of 11 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dzmitryhil and @ysv)

Copy link
Contributor

@dzmitryhil dzmitryhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 10 of 78 files reviewed, all discussions resolved (waiting on @masihyeganeh and @ysv)

dzmitryhil
dzmitryhil previously approved these changes Nov 21, 2024
Copy link
Contributor

@dzmitryhil dzmitryhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 10 of 11 files at r1, 68 of 68 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @masihyeganeh and @ysv)

masihyeganeh
masihyeganeh previously approved these changes Nov 21, 2024
Copy link
Contributor

@masihyeganeh masihyeganeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 68 of 68 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ysv)

@miladz68 miladz68 dismissed stale reviews from masihyeganeh and dzmitryhil via 8a4f09b November 21, 2024 07:46
Copy link
Contributor

@masihyeganeh masihyeganeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 11 of 11 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ysv)

Copy link
Contributor

@dzmitryhil dzmitryhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 11 of 11 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ysv)

@miladz68 miladz68 merged commit 31502e2 into master Nov 21, 2024
11 checks passed
@miladz68 miladz68 deleted the milad/update-go-version branch November 21, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants