Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate order sequence into new DEX events and order queries. #1027

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

dzmitryhil
Copy link
Contributor

@dzmitryhil dzmitryhil commented Nov 19, 2024

Description

Integrate order sequence into new DEX events and order queries.

  • Integrate new DEX events with the min required info
  • Add order sequence to all queries returning order(s)
  • Update all required tests + add extra to test the events consistency
  • Update genesis import/export to import/export current order sequence
  • Update naming of the order sequence
  • Describe DEX events in the spec.

Reviewers checklist:

  • Try to write more meaningful comments with clear actions to be taken.
  • Nit-picking should be unblocking. Focus on core issues.

Authors checklist

  • Provide a concise and meaningful description
  • Review the code yourself first, before making the PR.
  • Annotate your PR in places that require explanation.
  • Think and try to split the PR to smaller PR if it is big.

This change is Reviewable

* Integrate new DEX events with the min required info
* Add order sequence to all queries returning order(s)
* Update all required tests + add extra to test the events consistency
* Update genesis import/export to import/export current order sequence
* Update naming of the order sequence
* Describe DEX events in the spec.
@dzmitryhil dzmitryhil requested a review from a team as a code owner November 19, 2024 10:47
@dzmitryhil dzmitryhil requested review from masihyeganeh, miladz68 and ysv and removed request for a team November 19, 2024 10:47
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 85.84475% with 31 lines in your changes missing coverage. Please review.

Project coverage is 57.86%. Comparing base (5a00fe2) to head (fc94e4e).
Report is 23 commits behind head on master.

Files with missing lines Patch % Lines
x/dex/keeper/keeper.go 89.89% 3 Missing and 7 partials ⚠️
x/dex/genesis.go 65.21% 4 Missing and 4 partials ⚠️
x/dex/keeper/keeper_matching.go 73.91% 4 Missing and 2 partials ⚠️
x/dex/keeper/keeper_store.go 78.57% 2 Missing and 1 partial ⚠️
x/dex/keeper/keeper_good_til.go 88.23% 0 Missing and 2 partials ⚠️
x/dex/types/genesis.go 71.42% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1027      +/-   ##
==========================================
- Coverage   63.30%   57.86%   -5.44%     
==========================================
  Files         159      159              
  Lines       18308    18320      +12     
==========================================
- Hits        11590    10601     -989     
- Misses       5691     6736    +1045     
+ Partials     1027      983      -44     
Flag Coverage Δ
coreum 57.86% <85.84%> (-0.01%) ⬇️
coreum-integration-tests-modules 0.00% <0.00%> (-53.31%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

masihyeganeh
masihyeganeh previously approved these changes Nov 20, 2024
Copy link
Contributor

@masihyeganeh masihyeganeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 30 of 30 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @miladz68 and @ysv)

Copy link
Contributor

@masihyeganeh masihyeganeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @miladz68 and @ysv)

Copy link
Contributor

@miladz68 miladz68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 30 of 30 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ysv)

@dzmitryhil dzmitryhil merged commit 9d1fbbd into master Nov 20, 2024
10 of 11 checks passed
@dzmitryhil dzmitryhil deleted the dzmitryhil/integrate-new-dex-events-and-order-seq branch November 20, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants