-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate order sequence into new DEX events and order queries. #1027
Integrate order sequence into new DEX events and order queries. #1027
Conversation
* Integrate new DEX events with the min required info * Add order sequence to all queries returning order(s) * Update all required tests + add extra to test the events consistency * Update genesis import/export to import/export current order sequence * Update naming of the order sequence * Describe DEX events in the spec.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1027 +/- ##
==========================================
- Coverage 63.30% 57.86% -5.44%
==========================================
Files 159 159
Lines 18308 18320 +12
==========================================
- Hits 11590 10601 -989
- Misses 5691 6736 +1045
+ Partials 1027 983 -44
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 30 of 30 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @miladz68 and @ysv)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @miladz68 and @ysv)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 30 of 30 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ysv)
Description
Integrate order sequence into new DEX events and order queries.
Reviewers checklist:
Authors checklist
This change is