Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate DEX-related asset FT queries and messages for the WASM. #1031

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

dzmitryhil
Copy link
Contributor

@dzmitryhil dzmitryhil commented Nov 26, 2024

Description

  • Allow to use DEX-related asset FT queries for the WASM smart contracts.
  • Add integration tests to test it.

Reviewers checklist:

  • Try to write more meaningful comments with clear actions to be taken.
  • Nit-picking should be unblocking. Focus on core issues.

Authors checklist

  • Provide a concise and meaningful description
  • Review the code yourself first, before making the PR.
  • Annotate your PR in places that require explanation.
  • Think and try to split the PR to smaller PR if it is big.

This change is Reviewable

* Allow to use DEX-related asset FT queries for the WASM smart contracts.
* Add integration tests to test it.
@dzmitryhil dzmitryhil requested a review from a team as a code owner November 26, 2024 10:32
@dzmitryhil dzmitryhil requested review from masihyeganeh, miladz68 and ysv and removed request for a team November 26, 2024 10:32
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.43%. Comparing base (b5a4514) to head (72f848a).
Report is 18 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1031   +/-   ##
=======================================
  Coverage   62.43%   62.43%           
=======================================
  Files         159      159           
  Lines       18542    18542           
=======================================
  Hits        11577    11577           
  Misses       5852     5852           
  Partials     1113     1113           
Flag Coverage Δ
coreum 57.07% <100.00%> (ø)
coreum-integration-tests-modules 52.59% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@masihyeganeh masihyeganeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 16 of 17 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @miladz68 and @ysv)

Copy link
Contributor

@miladz68 miladz68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 16 of 17 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ysv)

@dzmitryhil dzmitryhil merged commit d4d888b into master Nov 27, 2024
11 checks passed
@dzmitryhil dzmitryhil deleted the dzmitryhil/asset-ft-dex-wasm-sdk branch November 27, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants