Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update extensions integration to check asset FT rules before calling the extensions. #1033

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

dzmitryhil
Copy link
Contributor

@dzmitryhil dzmitryhil commented Nov 28, 2024

Description

Update extensions integration to check asset FT rules before calling the extensions.

Reviewers checklist:

  • Try to write more meaningful comments with clear actions to be taken.
  • Nit-picking should be unblocking. Focus on core issues.

Authors checklist

  • Provide a concise and meaningful description
  • Review the code yourself first, before making the PR.
  • Annotate your PR in places that require explanation.
  • Think and try to split the PR to smaller PR if it is big.

This change is Reviewable

@dzmitryhil dzmitryhil requested a review from a team as a code owner November 28, 2024 06:36
@dzmitryhil dzmitryhil requested review from masihyeganeh, miladz68 and ysv and removed request for a team November 28, 2024 06:36
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

Attention: Patch coverage is 81.96721% with 11 lines in your changes missing coverage. Please review.

Project coverage is 62.42%. Comparing base (d4d888b) to head (616a122).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
x/asset/ft/keeper/before_send.go 60.00% 6 Missing and 4 partials ⚠️
x/asset/ft/keeper/keeper_dex.go 95.83% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1033      +/-   ##
==========================================
- Coverage   62.43%   62.42%   -0.01%     
==========================================
  Files         159      159              
  Lines       18542    18535       -7     
==========================================
- Hits        11577    11571       -6     
+ Misses       5852     5851       -1     
  Partials     1113     1113              
Flag Coverage Δ
coreum 57.06% <81.96%> (-0.02%) ⬇️
coreum-integration-tests-modules 52.55% <72.13%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@masihyeganeh masihyeganeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 12 of 12 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @miladz68 and @ysv)

Copy link
Contributor

@miladz68 miladz68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 12 of 12 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ysv)

@dzmitryhil dzmitryhil merged commit 8a6828d into master Nov 29, 2024
11 checks passed
@dzmitryhil dzmitryhil deleted the dzmitryhil/extensions-with-asset-ft-rules branch November 29, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants