Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

back port math dependency upgrade to v4 branch #1047

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

miladz68
Copy link
Contributor

@miladz68 miladz68 commented Dec 9, 2024

Description

Reviewers checklist:

  • Try to write more meaningful comments with clear actions to be taken.
  • Nit-picking should be unblocking. Focus on core issues.

Authors checklist

  • Provide a concise and meaningful description
  • Review the code yourself first, before making the PR.
  • Annotate your PR in places that require explanation.
  • Think and try to split the PR to smaller PR if it is big.

This change is Reviewable

@miladz68 miladz68 requested a review from a team as a code owner December 9, 2024 08:20
@miladz68 miladz68 requested review from masihyeganeh, dzmitryhil and ysv and removed request for a team December 9, 2024 08:20
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.13%. Comparing base (f8dba1b) to head (3902457).
Report is 1 commits behind head on release-v4.

Additional details and impacted files
@@              Coverage Diff               @@
##           release-v4    #1047      +/-   ##
==============================================
- Coverage       66.61%   64.13%   -2.49%     
==============================================
  Files             134      134              
  Lines           13076    13076              
==============================================
- Hits             8711     8386     -325     
- Misses           3631     3965     +334     
+ Partials          734      725       -9     
Flag Coverage Δ
coreum 58.34% <ø> (ø)
coreum-integration-tests-modules 44.72% <ø> (-5.67%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

masihyeganeh
masihyeganeh previously approved these changes Dec 9, 2024
Copy link
Contributor

@masihyeganeh masihyeganeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dzmitryhil and @ysv)

dzmitryhil
dzmitryhil previously approved these changes Dec 9, 2024
Copy link
Contributor

@dzmitryhil dzmitryhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ysv)

@miladz68 miladz68 dismissed stale reviews from dzmitryhil and masihyeganeh via 3902457 December 11, 2024 10:01
Copy link
Contributor

@masihyeganeh masihyeganeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ysv)

Copy link
Contributor

@dzmitryhil dzmitryhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ysv)

@miladz68 miladz68 merged commit 45f88ed into release-v4 Dec 12, 2024
8 of 9 checks passed
@miladz68 miladz68 deleted the milad/backport-math-dep-upgrade branch December 12, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants