-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add upgrade integration-tests checking gov proposal migration v45->v47 #655
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 3 files reviewed, 2 unresolved discussions (waiting on @dzmitryhil, @miladz68, and @wojtek-coreum)
integration-tests/upgrade/gov_migration_test.go
line 96 at r1 (raw file):
requireT.NoError(err) requireT.Equal(govtypesv1.StatusDepositPeriod, proposal.Status) requireT.Equal("", proposal.Proposer) // question here
even though we pass proposer when creating proposal after migration it is not present
This was discussed originally here https://reviewable.io/reviews/CoreumFoundation/coreum/625#-NcgDTM81q-QOMHh9chY
But I'm not sure if we should add step to set proposer inside upgrade since this proposal fails anyway
integration-tests/upgrade/gov_migration_test.go
line 123 at r1 (raw file):
proposalStatus, err := chain.Governance.WaitForVotingToFinalize(ctx, gmt.onDepositProposalId) requireT.NoError(err) requireT.Equal(govtypesv1.StatusFailed, proposalStatus)
So here it wasn't actually what I expected
As @dzmitryhil predicted, there is no handler for old proposal type and it failed.
Logs from cored:
11:31AM INF proposal tallied module=x/gov proposal=1 results="passed, but msg 0 (/cosmos.gov.v1.MsgExecLegacyContent) failed on execution: distribution: no handler exists for proposal type"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 3 files reviewed, all discussions resolved (waiting on @miladz68 and @wojtek-coreum)
integration-tests/upgrade/gov_migration_test.go
line 123 at r1 (raw file):
Previously, ysv (Yaroslav Savchuk) wrote…
So here it wasn't actually what I expected
As @dzmitryhil predicted, there is no handler for old proposal type and it failed.
Logs from cored:
11:31AM INF proposal tallied module=x/gov proposal=1 results="passed, but msg 0 (/cosmos.gov.v1.MsgExecLegacyContent) failed on execution: distribution: no handler exists for proposal type"
The chain is still running. And the test looks not 100% stable, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 3 files reviewed, all discussions resolved (waiting on @miladz68 and @wojtek-coreum)
integration-tests/upgrade/gov_migration_test.go
line 123 at r1 (raw file):
chain is running after this test and everything works
And the test looks not 100% stable, right?
It is stable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 3 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @miladz68 and @ysv)
integration-tests/upgrade/gov_migration_test.go
line 127 at r2 (raw file):
requireT.Equal(govtypesv1.StatusFailed, proposalStatus) // Logs produced inside cored for such a proposal: // "proposal tallied module=x/gov proposal=1 results="passed, but msg 0 (/cosmos.gov.v1.MsgExecLegacyContent) failed on execution: distribution: no handler exists for proposal type"
It should be fixed, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @miladz68 and @ysv)
integration-tests/upgrade/gov_migration_test.go
line 123 at r1 (raw file):
Previously, ysv (Yaroslav Savchuk) wrote…
chain is running after this test and everything works
And the test looks not 100% stable, right?
It is stable
It it's stable let's keep it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @miladz68 and @wojtek-coreum)
integration-tests/upgrade/gov_migration_test.go
line 127 at r2 (raw file):
Previously, wojtek-coreum (Wojtek) wrote…
It should be fixed, right?
No this is expected and we agreed to keep it
I just put the error which is produced during this proposal execution to have better explanation of what happens
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 3 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @wojtek-coreum and @ysv)
integration-tests/upgrade/gov_migration_test.go
line 127 at r2 (raw file):
Previously, ysv (Yaroslav Savchuk) wrote…
No this is expected and we agreed to keep it
I just put the error which is produced during this proposal execution to have better explanation of what happens
change is not needed.
Description
This PR adds upgrade integration-test where we:
Reviewers checklist:
Authors checklist
This change is