Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set new paramers for gov module in sdk v0.47 #661

Merged
merged 3 commits into from
Sep 26, 2023
Merged

Set new paramers for gov module in sdk v0.47 #661

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c69008e
Set new paramers for gov module in sdk v0.47
miladz68 Sep 25, 2023
1a579ef
pass tests
miladz68 Sep 26, 2023
948f3a3
Merge branch 'master' into milad/set-gov-params
miladz68 Sep 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/upgrade/v3/upgrade.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,9 +161,9 @@ func New(
// TODO(new-gov-params): Discuss new values for the following params with the team and set here & inside genesis.v3.json.
// min_initial_deposit_ratio, burn_vote_quorum, burn_proposal_deposit_prevote, burn_vote_veto
govParams := govKeeper.GetParams(ctx)
govParams.MinInitialDepositRatio = sdk.NewDec(0).Quo(sdk.NewDec(100)).String()
govParams.MinInitialDepositRatio = sdk.NewDec(50).Quo(sdk.NewDec(100)).String()
govParams.BurnVoteQuorum = false
govParams.BurnProposalDepositPrevote = false
govParams.BurnProposalDepositPrevote = true
govParams.BurnVoteVeto = true
if err := govKeeper.SetParams(ctx, govParams); err != nil {
return nil, err
Expand Down
4 changes: 2 additions & 2 deletions integration-tests/upgrade/params_migration_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,9 +169,9 @@ func (pmt *paramsMigrationTest) After(t *testing.T) {
Quorum: pmt.govParamsBeforeMigration.TallyParams.Quorum.String(),
Threshold: pmt.govParamsBeforeMigration.TallyParams.Threshold.String(),
VetoThreshold: pmt.govParamsBeforeMigration.TallyParams.VetoThreshold.String(),
MinInitialDepositRatio: sdk.ZeroDec().String(),
MinInitialDepositRatio: sdk.MustNewDecFromStr("0.5").String(),
BurnVoteQuorum: false,
BurnProposalDepositPrevote: false,
BurnProposalDepositPrevote: true,
BurnVoteVeto: true,
}
assertT.Equal(paramsBeforeMigration, govParams)
Expand Down