Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented burn authz handler #663

Merged
merged 5 commits into from
Oct 2, 2023
Merged

Implemented burn authz handler #663

merged 5 commits into from
Oct 2, 2023

Conversation

miladz68
Copy link
Contributor

@miladz68 miladz68 commented Sep 29, 2023

Description

This PR intoruduces authz handler to grant burn athorization with quota.

Reviewers checklist:

  • Try to write more meaningful comments with clear actions to be taken.
  • Nit-picking should be unblocking. Focus on core issues.

Authors checklist

  • Provide a concise and meaningful description
  • Review the code yourself first, before making the PR.
  • Annotate your PR in places that require explanation.
  • Think and try to split the PR to smaller PR if it is big.

This change is Reviewable

@miladz68 miladz68 requested a review from a team as a code owner September 29, 2023 10:15
@miladz68 miladz68 requested review from dzmitryhil, ysv, wojtek-coreum and keyleu and removed request for a team September 29, 2023 10:15
Copy link
Contributor

@dzmitryhil dzmitryhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 7 files reviewed, 1 unresolved discussion (waiting on @keyleu, @miladz68, @wojtek-coreum, and @ysv)


x/asset/ft/types/burn_authorization.go line 48 at r1 (raw file):

	}

	if !a.BurnLimit.IsAllPositive() {

Looks like IsAllPositive convers the len(a.BurnLimit) == 0 condition.

Copy link
Contributor Author

@miladz68 miladz68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 7 files reviewed, 1 unresolved discussion (waiting on @dzmitryhil, @keyleu, @wojtek-coreum, and @ysv)


x/asset/ft/types/burn_authorization.go line 48 at r1 (raw file):

Previously, dzmitryhil (Dzmitry Hil) wrote…

Looks like IsAllPositive convers the len(a.BurnLimit) == 0 condition.

But I don't check the length in validate basic.

Copy link
Contributor Author

@miladz68 miladz68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 7 files reviewed, 1 unresolved discussion (waiting on @dzmitryhil, @keyleu, @wojtek-coreum, and @ysv)


x/asset/ft/types/burn_authorization.go line 48 at r1 (raw file):

Previously, miladz68 (milad) wrote…

But I don't check the length in validate basic.

I see I do it for burn and not mint. Removed.

Copy link
Contributor

@dzmitryhil dzmitryhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 8 files reviewed, all discussions resolved (waiting on @keyleu, @wojtek-coreum, and @ysv)

dzmitryhil
dzmitryhil previously approved these changes Oct 2, 2023
Copy link
Contributor

@dzmitryhil dzmitryhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 7 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @keyleu, @wojtek-coreum, and @ysv)

Copy link
Collaborator

@keyleu keyleu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 7 files at r1, 2 of 2 files at r2, 3 of 3 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @wojtek-coreum and @ysv)

Copy link
Contributor

@dzmitryhil dzmitryhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @wojtek-coreum and @ysv)

@miladz68 miladz68 merged commit 2481ade into master Oct 2, 2023
8 checks passed
@miladz68 miladz68 deleted the milad/burn_authz branch October 2, 2023 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants