Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch all branches in CI #671

Closed
wants to merge 3 commits into from
Closed

Conversation

wojtek-coreum
Copy link
Collaborator

@wojtek-coreum wojtek-coreum commented Oct 13, 2023

Description

By default, checkout action fetches only the current branch. But to run backward compatibility check on proto files, master is needed too.

Reviewers checklist:

  • Try to write more meaningful comments with clear actions to be taken.
  • Nit-picking should be unblocking. Focus on core issues.

Authors checklist

  • Provide a concise and meaningful description
  • Review the code yourself first, before making the PR.
  • Annotate your PR in places that require explanation.
  • Think and try to split the PR to smaller PR if it is big.

This change is Reviewable

@wojtek-coreum wojtek-coreum requested a review from a team as a code owner October 13, 2023 09:32
@wojtek-coreum wojtek-coreum requested review from dzmitryhil, miladz68 and ysv and removed request for a team October 13, 2023 09:32
Copy link
Contributor

@ysv ysv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dzmitryhil, @miladz68, and @wojtek-coreum)


.github/workflows/ci.yml line 71 at r1 (raw file):

        uses: actions/checkout@v3
        with:
          fetch-depth: 0 # needed for proto backward compatibility check

does it literarily mean to fetch all branches existing inside repo ?

does it influence CI time a lot ?
Is there an option to just fetch PR branch and master ?

Copy link
Collaborator Author

@wojtek-coreum wojtek-coreum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dzmitryhil, @miladz68, and @ysv)


.github/workflows/ci.yml line 71 at r1 (raw file):

Previously, ysv (Yaroslav Savchuk) wrote…

does it literarily mean to fetch all branches existing inside repo ?

does it influence CI time a lot ?
Is there an option to just fetch PR branch and master ?

Yes, it fetches entire repo. I don't know how it affects the timeout. But I see in this PR that it doesn't solve the problem anyway, I don't know why? (linter is failing)

@wojtek-coreum wojtek-coreum deleted the wojtek/ci-fetch-depth branch October 13, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants