Run Cosmos relayer process inside TestIBCCallFromSmartContract integration test

[ysv]

Description

This PR changes TestIBCCallFromSmartContract to start and stop cosmos relayer inside test.
We need this to fully remove Cosmos Relayer from crust because that is the only place where we need it.

Reviewers checklist:

• Try to write more meaningful comments with clear actions to be taken.
• Nit-picking should be unblocking. Focus on core issues.

Authors checklist

• Provide a concise and meaningful description
• Review the code yourself first, before making the PR.
• Annotate your PR in places that require explanation.
• Think and try to split the PR to smaller PR if it is big.

---

This change is 

[dzmitryhil]

Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @miladz68, @wojtek-coreum, and @ysv)

---

integration-tests/ibc/ibc.go line 69 at r1 (raw file):

	pathName := fmt.Sprintf("%s-%s", srcChain.ChainSettings.ChainID, dstChain.ChainSettings.ChainID)

	// port name samples:

Why do we need that here?

---

integration-tests/ibc/ibc.go line 110 at r1 (raw file):

	go func() {
		err := <-relErrCh
		if !errors.Is(err, context.Canceled) {

Why do you ignore all errors a part form context.Canceled ?

[dzmitryhil]

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @miladz68, @wojtek-coreum, and @ysv)

[ysv]

Reviewable status: 1 of 2 files reviewed, 2 unresolved discussions (waiting on @dzmitryhil, @miladz68, and @wojtek-coreum)

---

integration-tests/ibc/ibc.go line 69 at r1 (raw file):

Previously, dzmitryhil (Dzmitry Hil) wrote…

Why do we need that here?

removed

---

integration-tests/ibc/ibc.go line 110 at r1 (raw file):

Previously, dzmitryhil (Dzmitry Hil) wrote…

Why do you ignore all errors a part form context.Canceled ?

fixed, good point

The idea is to ignore context.Canceled and don't report it as test failure but do report all other errors

[miladz68]

Reviewed 1 of 2 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @dzmitryhil and @wojtek-coreum)

[wojtek-coreum]

Reviewed 1 of 2 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @dzmitryhil and @ysv)

---

integration-tests/ibc/ibc.go line 110 at r2 (raw file):

			return
		}
		require.NoError(t, err, "Cosmos Relayer start error")

require.* functions don't work as expected inside goroutines and cannot be used there

---

integration-tests/ibc/wasm_test.go line 162 at r2 (raw file):

// TestIBCCallFromSmartContract tests the WASM contract calls via WASM IBC channel.
func TestIBCCallFromSmartContract(t *testing.T) {
	// Temporary skip this test because it is incompatible with crust but crust PR needs changes from coreum.

Add TODO or FIXME here

[dzmitryhil]

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @ysv)

---

integration-tests/ibc/ibc.go line 110 at r1 (raw file):

Previously, ysv (Yaroslav Savchuk) wrote…

fixed, good point

The idea is to ignore context.Canceled and don't report it as test failure but do report all other errors

With this I'm OK.

[ysv]

Reviewable status: 0 of 3 files reviewed, 3 unresolved discussions (waiting on @dzmitryhil, @miladz68, and @wojtek-coreum)

---

integration-tests/ibc/ibc.go line 110 at r1 (raw file):

Previously, dzmitryhil (Dzmitry Hil) wrote…

With this I'm OK.

Done.

---

integration-tests/ibc/ibc.go line 110 at r2 (raw file):

Previously, wojtek-coreum (Wojtek) wrote…

require.* functions don't work as expected inside goroutines and cannot be used there

refactored

---

integration-tests/ibc/wasm_test.go line 162 at r2 (raw file):

Previously, wojtek-coreum (Wojtek) wrote…

Add TODO or FIXME here

Done.

[ysv]

Reviewable status: 0 of 3 files reviewed, 4 unresolved discussions (waiting on @dzmitryhil, @miladz68, and @wojtek-coreum)

a discussion (no related file):
It seems that we don't need these changes

---

[ysv]

Not needed
Relaying via Hermes works