Testing transfers to non-whitelisted smart contract

[wojtek-coreum]

Description

Funds might be transferred to smart contract in 3 ways:

1. regular bank send
2. smart contract call
3. smart contract instantiation

In this PR, tests are added to verify that in all 3 cases transfer fails if smart contract is not whitelisted.

Reviewers checklist:

• Try to write more meaningful comments with clear actions to be taken.
• Nit-picking should be unblocking. Focus on core issues.

Authors checklist

• Provide a concise and meaningful description
• Review the code yourself first, before making the PR.
• Annotate your PR in places that require explanation.
• Think and try to split the PR to smaller PR if it is big.

---

This change is 

[ysv]

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dzmitryhil, @miladz68, and @wojtek-coreum)

---

integration-tests/modules/assetft_test.go line 2387 at r1 (raw file):

// TestAssetFTSendingToNonWhitelistedSmartContractIsDenied verifies that this is not possible to send token to smart contract
// if it is not whitelisted.
func TestAssetFTSendingToNonWhitelistedSmartContractIsDenied(t *testing.T) {

nit: I would squash these 3 into a single test since they test similar functionality and this will reduce amount of code significantly

[dzmitryhil]

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @miladz68 and @wojtek-coreum)

[miladz68]

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @wojtek-coreum)

---

integration-tests/modules/assetft_test.go line 2453 at r1 (raw file):

	}
	_, err = client.BroadcastTx(ctx, clientCtx.WithFromAddress(issuer), txf, sendMsg)
	requireT.Error(err)

assert error type.

---

integration-tests/modules/assetft_test.go line 2520 at r1 (raw file):

	requireT.NoError(err)
	_, err = chain.Wasm.ExecuteWASMContract(ctx, txf, issuer, contractAddr, incrementPayload, sdk.NewInt64Coin(denom, 100))
	requireT.Error(err)

assert error type

---

integration-tests/modules/assetft_test.go line 2583 at r1 (raw file):

		},
	)
	requireT.Error(err)

assert error type

[wojtek-coreum]

Reviewable status: 0 of 1 files reviewed, 3 unresolved discussions (waiting on @dzmitryhil, @miladz68, and @ysv)

---

integration-tests/modules/assetft_test.go line 2453 at r1 (raw file):

Previously, miladz68 (milad) wrote…

assert error type.

Done.

---

integration-tests/modules/assetft_test.go line 2520 at r1 (raw file):

Previously, miladz68 (milad) wrote…

assert error type

Done.

---

integration-tests/modules/assetft_test.go line 2583 at r1 (raw file):

Previously, miladz68 (milad) wrote…

assert error type

Done.

[dzmitryhil]

Reviewable status: 0 of 1 files reviewed, 3 unresolved discussions (waiting on @miladz68 and @ysv)

---

integration-tests/modules/assetft_test.go line 2453 at r1 (raw file):

Previously, wojtek-coreum (Wojtek) wrote…

Done.

You should be able to assert ErrWhitelistedLimitExceeded type not string (same in other places).

[dzmitryhil]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @miladz68)

[wojtek-coreum]

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @miladz68)

---

integration-tests/modules/assetft_test.go line 2453 at r1 (raw file):

Previously, dzmitryhil (Dzmitry Hil) wrote…

You should be able to assert ErrWhitelistedLimitExceeded type not string (same in other places).

no, because errors are returned from simulation, and those errors are not typed

[dzmitryhil]

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @miladz68)

[dzmitryhil]

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @miladz68)

[miladz68]

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dzmitryhil)

---

integration-tests/modules/assetft_test.go line 2453 at r1 (raw file):

Previously, wojtek-coreum (Wojtek) wrote…

no, because errors are returned from simulation, and those errors are not typed

but it is not a simultaion !

[wojtek-coreum]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @miladz68)

---

integration-tests/modules/assetft_test.go line 2453 at r1 (raw file):

Previously, miladz68 (milad) wrote…

but it is not a simultaion !

yea, I rewrote a test a bit to turn off simulation for this transaction and now error type is asserted

[miladz68]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @wojtek-coreum)