-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added cli for nft send authorization #691
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dzmitryhil, @miladz68, and @ysv)
x/asset/nft/client/cli/tx.go
line 25 at r1 (raw file):
// Flags defined on transactions. const ( AuthzFlag = "authz"
maybe "auth-file"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dzmitryhil, @wojtek-coreum, and @ysv)
x/asset/nft/client/cli/tx.go
line 25 at r1 (raw file):
Previously, wojtek-coreum (Wojtek) wrote…
maybe "auth-file"?
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed (commit messages unreviewed), 1 unresolved discussion (waiting on @wojtek-coreum and @ysv)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @miladz68 and @ysv)
x/asset/nft/client/cli/tx.go
line 556 at r2 (raw file):
func CmdGrantAuthorization() *cobra.Command { cmd := &cobra.Command{ Use: "grant [grantee] [message_type=\"send\"] --from <granter> --authz=path/to/authz.json",
--auth-file, or you may put %s here and pass param
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @wojtek-coreum and @ysv)
x/asset/nft/client/cli/tx.go
line 556 at r2 (raw file):
Previously, wojtek-coreum (Wojtek) wrote…
--auth-file, or you may put %s here and pass param
Done. passing it as argument means, we have to pass it in 3 different places, which defeats the purpose.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @miladz68 and @ysv)
x/asset/nft/client/cli/tx.go
line 25 at r3 (raw file):
// Flags defined on transactions. const ( AuthzFlag = "auth-file"
AuthFileFlag
x/asset/nft/client/cli/tx.go
line 572 at r3 (raw file):
] } `, version.AppName, version.AppName, constant.AddressSampleTest, AuthzFlag),
You pass the flag here, but you don't refer it inside string
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @wojtek-coreum and @ysv)
x/asset/nft/client/cli/tx.go
line 25 at r3 (raw file):
Previously, wojtek-coreum (Wojtek) wrote…
AuthFileFlag
Done
x/asset/nft/client/cli/tx.go
line 572 at r3 (raw file):
Previously, wojtek-coreum (Wojtek) wrote…
You pass the flag here, but you don't refer it inside string
yep, removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ysv)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ysv)
Description
Reviewers checklist:
Authors checklist
This change is