Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added cli for nft send authorization #691

Merged
merged 6 commits into from
Oct 31, 2023
Merged

Conversation

miladz68
Copy link
Contributor

@miladz68 miladz68 commented Oct 27, 2023

Description

Reviewers checklist:

  • Try to write more meaningful comments with clear actions to be taken.
  • Nit-picking should be unblocking. Focus on core issues.

Authors checklist

  • Provide a concise and meaningful description
  • Review the code yourself first, before making the PR.
  • Annotate your PR in places that require explanation.
  • Think and try to split the PR to smaller PR if it is big.

This change is Reviewable

@miladz68 miladz68 requested a review from a team as a code owner October 27, 2023 10:48
@miladz68 miladz68 requested review from dzmitryhil, ysv and wojtek-coreum and removed request for a team October 27, 2023 10:48
Copy link
Collaborator

@wojtek-coreum wojtek-coreum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dzmitryhil, @miladz68, and @ysv)


x/asset/nft/client/cli/tx.go line 25 at r1 (raw file):

// Flags defined on transactions.
const (
	AuthzFlag       = "authz"

maybe "auth-file"?

Copy link
Contributor Author

@miladz68 miladz68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dzmitryhil, @wojtek-coreum, and @ysv)


x/asset/nft/client/cli/tx.go line 25 at r1 (raw file):

Previously, wojtek-coreum (Wojtek) wrote…

maybe "auth-file"?

Done.

dzmitryhil
dzmitryhil previously approved these changes Oct 27, 2023
Copy link
Contributor

@dzmitryhil dzmitryhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed (commit messages unreviewed), 1 unresolved discussion (waiting on @wojtek-coreum and @ysv)

Copy link
Collaborator

@wojtek-coreum wojtek-coreum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @miladz68 and @ysv)


x/asset/nft/client/cli/tx.go line 556 at r2 (raw file):

func CmdGrantAuthorization() *cobra.Command {
	cmd := &cobra.Command{
		Use:   "grant [grantee] [message_type=\"send\"] --from <granter> --authz=path/to/authz.json",

--auth-file, or you may put %s here and pass param

Copy link
Contributor Author

@miladz68 miladz68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @wojtek-coreum and @ysv)


x/asset/nft/client/cli/tx.go line 556 at r2 (raw file):

Previously, wojtek-coreum (Wojtek) wrote…

--auth-file, or you may put %s here and pass param

Done. passing it as argument means, we have to pass it in 3 different places, which defeats the purpose.

Copy link
Collaborator

@wojtek-coreum wojtek-coreum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @miladz68 and @ysv)


x/asset/nft/client/cli/tx.go line 25 at r3 (raw file):

// Flags defined on transactions.
const (
	AuthzFlag       = "auth-file"

AuthFileFlag


x/asset/nft/client/cli/tx.go line 572 at r3 (raw file):

	]
}
`, version.AppName, version.AppName, constant.AddressSampleTest, AuthzFlag),

You pass the flag here, but you don't refer it inside string

Copy link
Contributor Author

@miladz68 miladz68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @wojtek-coreum and @ysv)


x/asset/nft/client/cli/tx.go line 25 at r3 (raw file):

Previously, wojtek-coreum (Wojtek) wrote…

AuthFileFlag

Done


x/asset/nft/client/cli/tx.go line 572 at r3 (raw file):

Previously, wojtek-coreum (Wojtek) wrote…

You pass the flag here, but you don't refer it inside string

yep, removed.

Copy link
Collaborator

@wojtek-coreum wojtek-coreum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ysv)

Copy link
Contributor

@dzmitryhil dzmitryhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ysv)

@miladz68 miladz68 merged commit 3e1b978 into master Oct 31, 2023
7 checks passed
@miladz68 miladz68 deleted the milad/nft-send-authz-cli branch October 31, 2023 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants