Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ledger-cosmos-go to make CLI work with new Ledger firmware #695

Merged
merged 11 commits into from
Nov 9, 2023

Conversation

ysv
Copy link
Contributor

@ysv ysv commented Oct 30, 2023

Description

cosmos/cosmos-sdk#18319

Reviewers checklist:

  • Try to write more meaningful comments with clear actions to be taken.
  • Nit-picking should be unblocking. Focus on core issues.

Authors checklist

  • Provide a concise and meaningful description
  • Review the code yourself first, before making the PR.
  • Annotate your PR in places that require explanation.
  • Think and try to split the PR to smaller PR if it is big.

This change is Reviewable

@ysv ysv requested a review from a team as a code owner October 30, 2023 17:37
@ysv ysv requested review from dzmitryhil, miladz68 and wojtek-coreum and removed request for a team October 30, 2023 17:37
@ysv ysv marked this pull request as draft October 30, 2023 17:37
@ysv ysv changed the title [DRAFT] Make CLI work with new Ledger firmware Make CLI work with new Ledger firmware Nov 2, 2023
@ysv ysv marked this pull request as ready for review November 2, 2023 15:39
@ysv ysv changed the title Make CLI work with new Ledger firmware Update ledger-cosmos-go to make CLI work with new Ledger firmware Nov 2, 2023
wojtek-coreum
wojtek-coreum previously approved these changes Nov 3, 2023
Copy link
Collaborator

@wojtek-coreum wojtek-coreum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dzmitryhil and @miladz68)

Copy link
Contributor

@dzmitryhil dzmitryhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 4 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @miladz68)

Copy link
Contributor

@dzmitryhil dzmitryhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @miladz68)

dzmitryhil
dzmitryhil previously approved these changes Nov 7, 2023
Copy link
Contributor

@dzmitryhil dzmitryhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @miladz68)

@ysv ysv dismissed stale reviews from dzmitryhil and wojtek-coreum via d9751d8 November 7, 2023 16:04
@ysv ysv force-pushed the yaroslav/fix-ledger-new-app branch from 164ef18 to d9751d8 Compare November 7, 2023 16:04
Copy link
Contributor

@dzmitryhil dzmitryhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r4.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @miladz68)

Copy link
Collaborator

@wojtek-coreum wojtek-coreum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r3, 1 of 1 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @miladz68)

@ysv ysv merged commit 5e7fbef into master Nov 9, 2023
7 checks passed
@ysv ysv deleted the yaroslav/fix-ledger-new-app branch November 9, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants