Close some TODO/FIXMEs & add more context to remaining ones (batch 1)

[ysv]

Description

Some TODOs which were not needed anymore were deleted.
And also I added v4 to most of left because they could not be fixed right now and will be resolved in v4+ release.
Other TODO/FIXME will be fixed in standalone PRs

Reviewers checklist:

• Try to write more meaningful comments with clear actions to be taken.
• Nit-picking should be unblocking. Focus on core issues.

Authors checklist

• Provide a concise and meaningful description
• Review the code yourself first, before making the PR.
• Annotate your PR in places that require explanation.
• Think and try to split the PR to smaller PR if it is big.

---

This change is 

[ysv]

Reviewable status: 0 of 9 files reviewed, 3 unresolved discussions (waiting on @dzmitryhil, @miladz68, and @wojtek-coreum)

---

app/app.go line 182 at r1 (raw file):

		gov.NewAppModuleBasic(
			[]govclient.ProposalHandler{
				// TODO(v4): Remove once IBC upgrades to the new param management mechanism. Check ibc-go/modules/core/02-client/types/params.go

IBC release a new version v7.3 but no changes related to params are included

---

app/upgrade/v3/upgrade.go line 107 at r1 (raw file):

				// coreum:
				// TODO(migration-away-from-x/params): Add migration of params for Coreum modules. Skipping them for now.

@miladz68
I saw you added assertions for our params in upgrade integratio tests also. Could you pls double check and verify if nothing is skipped

---

app/upgrade/v3/upgrade.go line 116 at r1 (raw file):

				if lo.Contains([]string{
					// TODO(migration-away-from-x/params): Add migration of params for Coreum modules. Skipping them for now.

@miladz68 pls double check
We don't need this for our modules, do we ?

[wojtek-coreum]

Reviewed 9 of 9 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @dzmitryhil, @miladz68, and @ysv)

---

x/deterministicgas/config.go line 82 at r1 (raw file):

		MsgToMsgURL(&assetfttypes.MsgGloballyUnfreeze{}):    constantGasFunc(5_000),
		MsgToMsgURL(&assetfttypes.MsgSetWhitelistedLimit{}): constantGasFunc(9_000),
		// Once we add a new token upgrade MsgUpgradeTokenV2 we should remove this one and re-estimate gas.

I think TODO should be kept here. Otherwise we won't find it.

[ysv]

Reviewable status: 6 of 19 files reviewed, 5 unresolved discussions (waiting on @dzmitryhil, @miladz68, and @wojtek-coreum)

---

tools/tools.go line 1 at r2 (raw file):

//go:build tools

@wojtek-coreum @miladz68 @dzmitryhil we don't need this file anymore, do we ?

---

x/deterministicgas/config.go line 82 at r1 (raw file):

Previously, wojtek-coreum (Wojtek) wrote…

I think TODO should be kept here. Otherwise we won't find it.

ok,
I don't think we need it because message will be added here and editor will see the comment but I'm ok to keep it

---

x/wnft/keeper/keeper.go line 31 at r3 (raw file):

// Send overwrites Send method of the original keeper.
// Copied from https://github.com/cosmos/cosmos-sdk/blob/a1143138716b64bc4fa0aa53c0f0fa59eb675bb7/x/nft/keeper/msg_server.go#L14
// FIXME(v47-nft-migration): once we update the nft to sdk nft, that methods must be updated as well.

this method is the same on current x/nft module
But we can't replace this hack anyhow so I keep it as it is

[dzmitryhil]

Reviewable status: 4 of 20 files reviewed, 5 unresolved discussions (waiting on @miladz68 and @wojtek-coreum)

---

tools/tools.go line 1 at r2 (raw file):

Previously, ysv (Yaroslav Savchuk) wrote…

@wojtek-coreum @miladz68 @dzmitryhil we don't need this file anymore, do we ?

That file was created for the ignite support, but I guess @wojtek-coreum extended it with the grpc-gateway to generate code. I guess we still needed.

[ysv]

Reviewable status: 4 of 20 files reviewed, 6 unresolved discussions (waiting on @miladz68 and @wojtek-coreum)

---

integration-tests/modules/wasm_test.go line 1960 at r5 (raw file):

			b[i] = letterRunes[rand.Intn(len(letterRunes))]
		}
		// Make sure string is not one of reserved subunits/symbols and if it is regenerate it.

the probability was quite low but it happened :)

subunit cannot start with ibc: invalid input: invalid input

https://github.com/CoreumFoundation/coreum/actions/runs/6748086865/job/18345681849?pr=702#step:13:2281

---

tools/tools.go line 1 at r2 (raw file):

Previously, dzmitryhil (Dzmitry Hil) wrote…

That file was created for the ignite support, but I guess @wojtek-coreum extended it with the grpc-gateway to generate code. I guess we still needed.

Because I found similar file in crust crust/build/tools/goinstall.go
And I think it replaces this one. So deps are installed from the one specified in crust

Waiting for Wojtek's input

[wojtek-coreum]

Reviewed 3 of 4 files at r2, 9 of 9 files at r3, 3 of 4 files at r4, 1 of 1 files at r5, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @miladz68)

---

tools/tools.go line 1 at r2 (raw file):

Previously, ysv (Yaroslav Savchuk) wrote…

Because I found similar file in crust crust/build/tools/goinstall.go
And I think it replaces this one. So deps are installed from the one specified in crust

Waiting for Wojtek's input

Fuck, I spent a day finding the correct packages in the source code of ignite and they were here all the time... Yeah, we don't need it anymore.

[dzmitryhil]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @miladz68)

[wojtek-coreum]

Reviewed 1 of 1 files at r6, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @miladz68)