Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minting recipient for AssetNFT and AssetFT, and SetFrozen for AssetFT on wasm #703

Merged
merged 2 commits into from
Nov 7, 2023

Conversation

keyleu
Copy link
Collaborator

@keyleu keyleu commented Nov 3, 2023

Description

  • Modify contracts to include the recipient in the minting operation.
  • Modify the wasm handler to correctly consider the recipient for AssetNFTs.

Reviewers checklist:

  • Try to write more meaningful comments with clear actions to be taken.
  • Nit-picking should be unblocking. Focus on core issues.

Authors checklist

  • Provide a concise and meaningful description
  • Review the code yourself first, before making the PR.
  • Annotate your PR in places that require explanation.
  • Think and try to split the PR to smaller PR if it is big.

This change is Reviewable

@keyleu keyleu requested a review from a team as a code owner November 3, 2023 22:42
@keyleu keyleu requested review from dzmitryhil, miladz68, ysv and wojtek-coreum and removed request for a team November 3, 2023 22:42
@keyleu keyleu changed the title Add minting recipient for AssetNFT and AssetFT Add minting recipient for AssetNFT and AssetFT on wasm Nov 3, 2023
dzmitryhil
dzmitryhil previously approved these changes Nov 6, 2023
Copy link
Contributor

@dzmitryhil dzmitryhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 13 of 13 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @miladz68, @wojtek-coreum, and @ysv)

@keyleu keyleu changed the title Add minting recipient for AssetNFT and AssetFT on wasm Add minting recipient for AssetNFT and AssetFT, and SetFrozen for AssetFT on wasm Nov 6, 2023
Copy link
Contributor

@ysv ysv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 13 files at r1, 10 of 10 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dzmitryhil, @miladz68, and @wojtek-coreum)

Copy link
Collaborator

@wojtek-coreum wojtek-coreum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 13 files at r1, 10 of 10 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dzmitryhil and @miladz68)

@keyleu keyleu merged commit 2ae43ed into master Nov 7, 2023
7 checks passed
@keyleu keyleu deleted the keyne/modify-minting-wasm branch November 7, 2023 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants