Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration test of direct AUX signing mode #704

Merged
merged 13 commits into from
Nov 15, 2023
Merged

Integration test of direct AUX signing mode #704

merged 13 commits into from
Nov 15, 2023

Conversation

wojtek-coreum
Copy link
Collaborator

@wojtek-coreum wojtek-coreum commented Nov 7, 2023 •
edited
Loading

Description

More info: https://docs.cosmos.network/v0.46/core/tips.html

Reviewers checklist:

  • Try to write more meaningful comments with clear actions to be taken.
  • Nit-picking should be unblocking. Focus on core issues.

Authors checklist

  • Provide a concise and meaningful description
  • Review the code yourself first, before making the PR.
  • Annotate your PR in places that require explanation.
  • Think and try to split the PR to smaller PR if it is big.

This change is Reviewable

@wojtek-coreum wojtek-coreum requested a review from a team as a code owner November 7, 2023 11:36
@wojtek-coreum wojtek-coreum requested review from dzmitryhil, miladz68 and ysv and removed request for a team November 7, 2023 11:36
dzmitryhil
dzmitryhil reviewed Nov 7, 2023
View reviewed changes
Copy link
Contributor

@dzmitryhil dzmitryhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @miladz68, @wojtek-coreum, and @ysv)

a discussion (no related file):
It would be nice to discuss that singing mode.

dzmitryhil
dzmitryhil previously approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@dzmitryhil dzmitryhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @miladz68 and @ysv)

ysv
ysv previously approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@ysv ysv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @miladz68)

@wojtek-coreum wojtek-coreum dismissed stale reviews from ysv and dzmitryhil via a2a314f November 13, 2023 09:05
ysv
ysv previously approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@ysv ysv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @miladz68)

Wojtek added 2 commits November 13, 2023 12:45
Merge remote-tracking branch 'origin/master' into wojtek/sign-mode-di…
d9a9f02 
…rect-aux

# Conflicts:
#	integration-tests/modules/auth_test.go
linter
bd50519
ysv
ysv previously approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@ysv ysv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @miladz68)

dzmitryhil
dzmitryhil approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@dzmitryhil dzmitryhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r5, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @miladz68)

ysv
ysv approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@ysv ysv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r5, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @miladz68)

@wojtek-coreum wojtek-coreum merged commit fbe6455 into master Nov 15, 2023
7 checks passed
@wojtek-coreum wojtek-coreum deleted the wojtek/sign-mode-direct-aux branch November 15, 2023 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ysv ysv ysv approved these changes

@dzmitryhil dzmitryhil dzmitryhil approved these changes

@miladz68 miladz68 Awaiting requested review from miladz68 miladz68 is a code owner automatically assigned from CoreumFoundation/team-blockchain

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wojtek-coreum @dzmitryhil @ysv