swap matrices, topocharge #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbyrne299
requested changes
Jun 28, 2024
| """ | ||
| return self._anyons | ||
|
|
||
| def get_state(self) -> State: |
There was a problem hiding this comment.
I know I said I was gonna add state to simulator so I'll edit anyways, but just FYI this get_state method makes it sound like there's already a state field that you're "getting". Classes often have "getter & setter" methods for this purpose, but that doesn't apply here, so a clearer name would've been smth like init_state. Not big deal though
| index_1 = self.get_anyon_index(anyon_A) | ||
| index_2 = self.get_anyon_index(anyon_B) | ||
| anyon_indices.append((index_1, index_2)) | ||
| return anyon_indices |
There was a problem hiding this comment.
this return statement should be outside the for loop, otherwise the loop will never go beyond the first iteration. the fact that your PR passed check/tests means that this function wasn't covered anywhere in the existing tests, so might be good to test this somewhere
rbyrne299
approved these changes
Jun 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.