Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

master to tests #139

Merged
merged 23 commits into from
Apr 3, 2024
Merged

master to tests #139

merged 23 commits into from
Apr 3, 2024

Conversation

yueyinqiu
Copy link
Member

@yueyinqiu yueyinqiu commented Apr 3, 2024

PR-Codex overview

This PR introduces enhancements related to game version info, HTTP requests, and system info search.

Detailed summary

  • Added GameBaseVersion property to VersionInfo
  • Updated GetGameJsonPath method in GamePathHelper
  • Changed Logging property to nullable in LegacyForgeInstallProfile
  • Modified Java executable paths in Constants
  • Added CancellationToken to HTTP requests
  • Updated package references in ProjBobcat.csproj
  • Added CancellationToken to GetProject method in ModrinthAPIHelper
  • Refactored Java search logic in SystemInfoHelper and DeepJavaSearcher
  • Improved redirect handling in RedirectHandler
  • Enhanced CloneHttpRequestMessageAsync method in RedirectHandler
  • Adjusted initialization of LauncherProfileParser in DefaultVersionLocator

The following files were skipped due to too many changes: ProjBobcat/ProjBobcat/DefaultComponent/Launch/DefaultVersionLocator.cs, ProjBobcat/ProjBobcat/Class/Helper/DownloadHelper.cs

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@yueyinqiu yueyinqiu merged commit 26aee22 into tests Apr 3, 2024
11 checks passed
Copy link

sonarcloud bot commented Apr 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants