Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

148 add paging functionality to blog posts podcast episodes events and projects overview #591

Conversation

leusi
Copy link
Collaborator

@leusi leusi commented Nov 1, 2023

Issue: #148

leusi added 8 commits May 12, 2023 13:33
…onality-to-blog-posts-podcast-episodes-events-and-projects-overview
…onality-to-blog-posts-podcast-episodes-events-and-projects-overview

# Conflicts:
#	src/routes/[[locale=locale]]/podcast/+page.svelte
…onality-to-blog-posts-podcast-episodes-events-and-projects-overview

# Conflicts:
#	src/lib/components/ProjectsCard.svelte
#	src/routes/[[locale=locale]]/[using_data=using_data]/[project_database=project_database]/[slug]/+page.svelte
…onality-to-blog-posts-podcast-episodes-events-and-projects-overview
…onality-to-blog-posts-podcast-episodes-events-and-projects-overview
Copy link

vercel bot commented Nov 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
correlaid ⬜️ Ignored (Inspect) Visit Preview Nov 1, 2023 8:44pm

Copy link

cloudflare-workers-and-pages bot commented Nov 1, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: a047fbb
Status: ✅  Deploy successful!
Preview URL: https://71319d1e.correlaid.pages.dev
Branch Preview URL: https://148-add-paging-functionality.correlaid.pages.dev

View logs

Copy link
Member

@jstet jstet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @leusi ,
thanks a lot for contributing!
The pagination component looks perfect to me.

@jstet
Copy link
Member

jstet commented Nov 1, 2023

Two small things: I have adjusted the aria-label and translated the vanilla css to tailwind in a047fbb

If you agree with my changes, I am happy to merge this.

@jstet
Copy link
Member

jstet commented Nov 8, 2023

I will merge this for now, @leusi should you disagree with my changes you are always welcome to open another PR

@jstet jstet merged commit dc61653 into main Nov 8, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add paging functionality to blog posts, podcast episodes, events and projects overview
2 participants