Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix isPush for push0 #1806

Merged
merged 1 commit into from
Nov 17, 2023
Merged

fix isPush for push0 #1806

merged 1 commit into from
Nov 17, 2023

Conversation

ucwong
Copy link
Member

@ucwong ucwong commented Nov 16, 2023

Fixes so that push0 opcode is correctly reported as true by the IsPush function


Fixes so that `push0` opcode is correctly reported as `true` by the `IsPush` function

---------

Co-authored-by: Martin Holst Swende <[email protected]>
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Merging #1806 (a452c2d) into master (3dccf54) will increase coverage by 0.03%.
Report is 375 commits behind head on master.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1806      +/-   ##
==========================================
+ Coverage   52.65%   52.69%   +0.03%     
==========================================
  Files         485      485              
  Lines       60538    60538              
==========================================
+ Hits        31879    31899      +20     
+ Misses      26203    26191      -12     
+ Partials     2456     2448       -8     
Files Coverage Δ
core/vm/opcodes.go 20.00% <0.00%> (ø)

... and 13 files with indirect coverage changes

@ucwong ucwong marked this pull request as ready for review November 17, 2023 09:00
@ucwong ucwong merged commit fe32360 into master Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants